[FIX] account_edi_ubl_cii: fix edi options on journal #94302
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
|
C3POdoo
requested review from
a team and
csnauwaert
and removed request for
a team
smetl
approved these changes
Jun 22, 2022
Contributor
|
@smetl, you may want to rebuild or fix this PR as it has failed CI. |
In 14.0, _is_enabled_by_default_on_journal does not exist, thus every edi.format is enabled by default. This commit allows to only have facturx enabled by default. In addition, we only want the edi.format options to appear on the sale journals (out_invoice, out_refund). Finally, the warnings are no longer displayed on top of the invoice.
JulienVR
force-pushed
the
14.0-account-edi-ubl-cii-fix-journal-juvr
branch
from
3f63fcf to
f38b563
Compare
Contributor
|
@robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Jun 22, 2022
In 14.0, _is_enabled_by_default_on_journal does not exist, thus every edi.format is enabled by default. This commit allows to only have facturx enabled by default. In addition, we only want the edi.format options to appear on the sale journals (out_invoice, out_refund). Finally, the warnings are no longer displayed on top of the invoice. closes #94302 Signed-off-by: Laurent Smet <[email protected]>
This was referenced Jun 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 14.0,
_is_enabled_by_default_on_journaldoes not exist, thusevery edi.format is enabled by default. This commit allows to only
have facturx enabled by default.
In addition, we only want the edi.format options to appear
on the sale journals (out_invoice, out_refund).
Finally, the warnings are no longer displayed on top of the invoice.