[FIX] crm: Lead 2 opportunities error when no salespersons #88108

lade-odoo · 2022-04-06T11:55:50Z

In a multi-company environment, when we transform a lead (which has
no salesperson) into an opportunity, we get an error.

To reproduce the issue:

Create a new company
Create a Lead for a customer with the Company set
Remove the Sales Team
Set the company on the Lead
Convert to an opportunity and you will see an error showing up

Solution:
A previous commit (1fad826) adapted the _compute_company_id
computation in which a case was forgotten (the case described here-above). The fix was to force
the company_id to the one of the partner_id if it has one.

opw-2805181

robodoo · 2022-04-06T11:56:05Z

kitan191

Technically, LGTM

lade-odoo · 2022-04-14T07:20:03Z

@tde-banana-odoo Can you review this ? Thanks !

tde-banana-odoo · 2022-04-26T10:17:11Z

FYI: some discussions are ongoing on task 2824913

lade-odoo · 2022-05-04T13:11:27Z

@tde-banana-odoo Is there any news regarding this issue ? Have you had the time to discuss it with others in the team ?

lade-odoo · 2022-05-10T15:22:15Z

@tde-banana-odoo Is there any news regarding this issue ? Have you had the time to discuss it with others in the team ?

tde-banana-odoo

Validation !

tde-banana-odoo · 2022-05-13T07:39:49Z

addons/crm/models/crm_lead.py

                    proposal = lead.user_id.company_id & self.env.companies
                elif lead.team_id:
                    proposal = lead.team_id.company_id
+                elif lead.partner_id and lead.partner_id.company_id:


I don't think we want to force a new company based on the customer's one ... shouldn't we keep it void instead ? Generally this means less issues.

This review contradicts your first one concerning splitting the if condition. We cannot apply both reviews, it would break the fix.

I would say that it's best to avoid having a void company in most cases as there are validation upon saving the record. Plus, the way the new condition is placed enforced to avoid having unnecessary warning message upon saving.

tde-banana-odoo · 2022-05-13T07:42:21Z

addons/crm/models/crm_lead.py

                    proposal = False
                # no user and no team -> void company and let assignment do its job
-                if not lead.team_id and not lead.user_id:
+                if not lead.team_id and not lead.user_id and not (lead.partner_id and proposal == lead.partner_id.company_id):


About code: would make a new entry in the "if" list to clearly explain the case, aka something like

# no user and no team -> void company and let assignment do its job if not lead.team_id and not lead.user_id: proposal = False # incompatible with partner's company if proposal and lead.partner_id.company_id != proposal: proposal= False

addons/crm/models/crm_lead.py

lade-odoo · 2022-05-19T07:55:44Z

@tde-banana-odoo Is the changes ok for you now ?

tde-banana-odoo · 2022-05-19T08:13:56Z

Hello,

I still did not have time to test in details. I am unsure this fix is the right one, and for tricky process like that I would prefer taking time to review it carefully. Will try to have a look soon :)

Currently using a customer with a company set on a lead without company crashes, as it keep a void company on the lead. This is not compatible with the company set on the partner itself. OPW-2805181 Task-2888330

tde-banana-odoo · 2022-06-20T11:42:59Z

Hello,

I added some tests and rebased. @tfr-odoo could you have a look and see if it is ok for you ?

Cheers !

In a multi-company environment, when we transform a lead (which has no salesperson) into an opportunity, we get an error if the customer has a company set. To reproduce the issue 1) Create a new company 2) Create a Lead for a customer with the Company set 3) Remove the Sales Team 4) Set the company on the Lead 5) Convert to an opportunity and you will see an error showing up Solution A previous commit (1fad826) adapted the `_compute_company_id` computation in which a case was forgotten (the case described here-above). The fix was to force the `company_id` to the one of the `partner_id` if it has one. OPW-2805181 Task-2888330

tfr-odoo · 2022-06-20T16:44:22Z

Hello,

I added some tests and rebased. @tfr-odoo could you have a look and see if it is ok for you ?

Cheers !

For odoo.com it won't make any difference since our partner have no company and check_company is False on crm.lead.

I found a bit sad to reach this level of complexity to ensure the company consistency on a object like lead where is not really needed but that's my humble opinion

Nevertheless this fix seems consistent

tde-banana-odoo · 2022-06-21T06:16:29Z

@tfr-odoo I agree this should probably be simplified, company check is a bit too aggressive for lead. But in stable we have to ensure it runs smoothly :) .

tde-banana-odoo · 2022-06-21T06:41:21Z

@robodoo r+ rebase-ff

robodoo · 2022-06-21T06:42:12Z

Merge method set to rebase and fast-forward

robodoo · 2022-06-21T07:03:14Z

Staging failed: ci/runbot (view more at https://runbot.odoo.com/runbot/build/16681036)

tde-banana-odoo · 2022-06-21T08:17:18Z

@robodoo retry

Currently using a customer with a company set on a lead without company crashes, as it keep a void company on the lead. This is not compatible with the company set on the partner itself. OPW-2805181 Task-2888330 Part-of: odoo#88108 X-original-commit: 51be6ca

In a multi-company environment, when we transform a lead (which has no salesperson) into an opportunity, we get an error if the customer has a company set. To reproduce the issue 1) Create a new company 2) Create a Lead for a customer with the Company set 3) Remove the Sales Team 4) Set the company on the Lead 5) Convert to an opportunity and you will see an error showing up Solution A previous commit (1fad826) adapted the `_compute_company_id` computation in which a case was forgotten (the case described here-above). The fix was to force the `company_id` to the one of the `partner_id` if it has one. OPW-2805181 Task-2888330 closes odoo#88108 Signed-off-by: Thibault Delavallee (tde) <[email protected]> X-original-commit: fc3bb66

In a multi-company environment, when we transform a lead (which has no salesperson) into an opportunity, we get an error if the customer has a company set. To reproduce the issue 1) Create a new company 2) Create a Lead for a customer with the Company set 3) Remove the Sales Team 4) Set the company on the Lead 5) Convert to an opportunity and you will see an error showing up Solution A previous commit (1fad826) adapted the `_compute_company_id` computation in which a case was forgotten (the case described here-above). The fix was to force the `company_id` to the one of the `partner_id` if it has one. OPW-2805181 Task-2888330 closes #88108 closes #94483 X-original-commit: fc3bb66 Signed-off-by: Thibault Delavallee (tde) <[email protected]>

In a multi-company environment, when we transform a lead (which has no salesperson) into an opportunity, we get an error if the customer has a company set. To reproduce the issue 1) Create a new company 2) Create a Lead for a customer with the Company set 3) Remove the Sales Team 4) Set the company on the Lead 5) Convert to an opportunity and you will see an error showing up Solution A previous commit (1fad826) adapted the `_compute_company_id` computation in which a case was forgotten (the case described here-above). The fix was to force the `company_id` to the one of the `partner_id` if it has one. OPW-2805181 Task-2888330 closes #88108 closes #94493 X-original-commit: fc3bb66 Signed-off-by: Thibault Delavallee (tde) <[email protected]>

In a multi-company environment, when we transform a lead (which has no salesperson) into an opportunity, we get an error if the customer has a company set. To reproduce the issue 1) Create a new company 2) Create a Lead for a customer with the Company set 3) Remove the Sales Team 4) Set the company on the Lead 5) Convert to an opportunity and you will see an error showing up Solution A previous commit (1fad826) adapted the `_compute_company_id` computation in which a case was forgotten (the case described here-above). The fix was to force the `company_id` to the one of the `partner_id` if it has one. OPW-2805181 Task-2888330 closes #88108 closes #94473 X-original-commit: fc3bb66 Signed-off-by: Thibault Delavallee (tde) <[email protected]>

In a multi-company environment, when we transform a lead (which has no salesperson) into an opportunity, we get an error if the customer has a company set. To reproduce the issue 1) Create a new company 2) Create a Lead for a customer with the Company set 3) Remove the Sales Team 4) Set the company on the Lead 5) Convert to an opportunity and you will see an error showing up Solution A previous commit (1fad826) adapted the `_compute_company_id` computation in which a case was forgotten (the case described here-above). The fix was to force the `company_id` to the one of the `partner_id` if it has one. OPW-2805181 Task-2888330 closes #88108 closes #94462 X-original-commit: fc3bb66 Signed-off-by: Thibault Delavallee (tde) <[email protected]>

In a multi-company environment, when we transform a lead (which has no salesperson) into an opportunity, we get an error if the customer has a company set. To reproduce the issue 1) Create a new company 2) Create a Lead for a customer with the Company set 3) Remove the Sales Team 4) Set the company on the Lead 5) Convert to an opportunity and you will see an error showing up Solution A previous commit (1fad826) adapted the `_compute_company_id` computation in which a case was forgotten (the case described here-above). The fix was to force the `company_id` to the one of the `partner_id` if it has one. OPW-2805181 Task-2888330 closes #88108 closes #94473 X-original-commit: fc3bb66 Signed-off-by: Thibault Delavallee (tde) <[email protected]>

fw-bot · 2022-06-25T05:53:15Z

This pull request has forward-port PRs awaiting action (not merged or closed): #94462, #94473

In a multi-company environment, when we transform a lead (which has no salesperson) into an opportunity, we get an error if the customer has a company set. To reproduce the issue 1) Create a new company 2) Create a Lead for a customer with the Company set 3) Remove the Sales Team 4) Set the company on the Lead 5) Convert to an opportunity and you will see an error showing up Solution A previous commit (1fad826) adapted the `_compute_company_id` computation in which a case was forgotten (the case described here-above). The fix was to force the `company_id` to the one of the `partner_id` if it has one. OPW-2805181 Task-2888330 closes #88108 closes #94462 X-original-commit: fc3bb66 Signed-off-by: Thibault Delavallee (tde) <[email protected]>

In a multi-company environment, when we transform a lead (which has no salesperson) into an opportunity, we get an error if the customer has a company set. To reproduce the issue 1) Create a new company 2) Create a Lead for a customer with the Company set 3) Remove the Sales Team 4) Set the company on the Lead 5) Convert to an opportunity and you will see an error showing up Solution A previous commit (1fad826) adapted the `_compute_company_id` computation in which a case was forgotten (the case described here-above). The fix was to force the `company_id` to the one of the `partner_id` if it has one. OPW-2805181 Task-2888330 closes #88108 closes #94473 X-original-commit: fc3bb66 Signed-off-by: Thibault Delavallee (tde) <[email protected]>

fw-bot · 2022-06-26T05:53:13Z

This pull request has forward-port PRs awaiting action (not merged or closed): #94462, #94473

fw-bot · 2022-06-27T05:53:47Z

This pull request has forward-port PRs awaiting action (not merged or closed): #94462, #94473

Currently using a customer with a company set on a lead without company crashes, as it keep a void company on the lead. This is not compatible with the company set on the partner itself. OPW-2805181 Task-2888330 Part-of: odoo#88108 X-original-commit: 51be6ca

In a multi-company environment, when we transform a lead (which has no salesperson) into an opportunity, we get an error if the customer has a company set. To reproduce the issue 1) Create a new company 2) Create a Lead for a customer with the Company set 3) Remove the Sales Team 4) Set the company on the Lead 5) Convert to an opportunity and you will see an error showing up Solution A previous commit (1fad826) adapted the `_compute_company_id` computation in which a case was forgotten (the case described here-above). The fix was to force the `company_id` to the one of the `partner_id` if it has one. OPW-2805181 Task-2888330 closes odoo#88108 Signed-off-by: Thibault Delavallee (tde) <[email protected]> X-original-commit: fc3bb66

Currently using a customer with a company set on a lead without company crashes, as it keep a void company on the lead. This is not compatible with the company set on the partner itself. OPW-2805181 Task-2888330 Part-of: odoo#88108 X-original-commit: 51be6ca

In a multi-company environment, when we transform a lead (which has no salesperson) into an opportunity, we get an error if the customer has a company set. To reproduce the issue 1) Create a new company 2) Create a Lead for a customer with the Company set 3) Remove the Sales Team 4) Set the company on the Lead 5) Convert to an opportunity and you will see an error showing up Solution A previous commit (1fad826) adapted the `_compute_company_id` computation in which a case was forgotten (the case described here-above). The fix was to force the `company_id` to the one of the `partner_id` if it has one. OPW-2805181 Task-2888330 closes odoo#88108 Signed-off-by: Thibault Delavallee (tde) <[email protected]> X-original-commit: fc3bb66

In a multi-company environment, when we transform a lead (which has no salesperson) into an opportunity, we get an error if the customer has a company set. To reproduce the issue 1) Create a new company 2) Create a Lead for a customer with the Company set 3) Remove the Sales Team 4) Set the company on the Lead 5) Convert to an opportunity and you will see an error showing up Solution A previous commit (1fad826) adapted the `_compute_company_id` computation in which a case was forgotten (the case described here-above). The fix was to force the `company_id` to the one of the `partner_id` if it has one. OPW-2805181 Task-2888330 closes #88108 closes #94473 X-original-commit: fc3bb66 Signed-off-by: Thibault Delavallee (tde) <[email protected]>

In a multi-company environment, when we transform a lead (which has no salesperson) into an opportunity, we get an error if the customer has a company set. To reproduce the issue 1) Create a new company 2) Create a Lead for a customer with the Company set 3) Remove the Sales Team 4) Set the company on the Lead 5) Convert to an opportunity and you will see an error showing up Solution A previous commit (1fad826) adapted the `_compute_company_id` computation in which a case was forgotten (the case described here-above). The fix was to force the `company_id` to the one of the `partner_id` if it has one. OPW-2805181 Task-2888330 closes #88108 closes #94462 X-original-commit: fc3bb66 Signed-off-by: Thibault Delavallee (tde) <[email protected]>

C3POdoo added the OE the report is linked to a support ticket (opw-...) label Apr 6, 2022

lade-odoo force-pushed the 15.0-opw-2805181-lead_2_opportunity_no_salesperson-lade branch from 872f971 to 33526d7 Compare April 13, 2022 14:20

kitan191 approved these changes Apr 14, 2022

View reviewed changes

lade-odoo marked this pull request as ready for review April 14, 2022 07:18

C3POdoo requested a review from a team April 14, 2022 07:19

lade-odoo closed this Apr 26, 2022

lade-odoo reopened this Apr 26, 2022

tde-banana-odoo reviewed May 13, 2022

View reviewed changes

tde-banana-odoo force-pushed the 15.0-opw-2805181-lead_2_opportunity_no_salesperson-lade branch from 33526d7 to beab457 Compare June 20, 2022 10:38

[IMP] crm: add tests for MC computation on lead with partner company

03dcff4

Currently using a customer with a company set on a lead without company crashes, as it keep a void company on the lead. This is not compatible with the company set on the partner itself. OPW-2805181 Task-2888330

tde-banana-odoo force-pushed the 15.0-opw-2805181-lead_2_opportunity_no_salesperson-lade branch 2 times, most recently from 40d97a5 to 0807e80 Compare June 20, 2022 11:41

tde-banana-odoo force-pushed the 15.0-opw-2805181-lead_2_opportunity_no_salesperson-lade branch from 0807e80 to 644c6e5 Compare June 20, 2022 12:14

fw-bot mentioned this pull request Jun 23, 2022

[FW][FIX] crm: Lead 2 opportunities error when no salespersons #94493

Closed

fw-bot deleted the 15.0-opw-2805181-lead_2_opportunity_no_salesperson-lade branch July 5, 2022 12:47

[FIX] crm: Lead 2 opportunities error when no salespersons #88108

[FIX] crm: Lead 2 opportunities error when no salespersons #88108

Uh oh!

Conversation

lade-odoo commented Apr 6, 2022

Uh oh!

robodoo commented Apr 6, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kitan191 left a comment

Choose a reason for hiding this comment

Uh oh!

lade-odoo commented Apr 14, 2022

Uh oh!

tde-banana-odoo commented Apr 26, 2022

Uh oh!

lade-odoo commented May 4, 2022

Uh oh!

lade-odoo commented May 10, 2022

Uh oh!

tde-banana-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

tde-banana-odoo May 13, 2022

Choose a reason for hiding this comment

Uh oh!

lade-odoo May 13, 2022

Choose a reason for hiding this comment

Uh oh!

tde-banana-odoo May 13, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

lade-odoo commented May 19, 2022

Uh oh!

tde-banana-odoo commented May 19, 2022

Uh oh!

tde-banana-odoo commented Jun 20, 2022

Uh oh!

tfr-odoo commented Jun 20, 2022

Uh oh!

tde-banana-odoo commented Jun 21, 2022

Uh oh!

tde-banana-odoo commented Jun 21, 2022

Uh oh!

robodoo commented Jun 21, 2022

Uh oh!

robodoo commented Jun 21, 2022

Uh oh!

tde-banana-odoo commented Jun 21, 2022

Uh oh!

fw-bot commented Jun 25, 2022

Uh oh!

fw-bot commented Jun 26, 2022

Uh oh!

fw-bot commented Jun 27, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

robodoo commented Apr 6, 2022 •

edited

Loading