[FIX] crm: set partner company on lead when resetting company

In a multi-company environment, when we transform a lead (which has no
salesperson) into an opportunity, we get an error if the customer has
a company set.

To reproduce the issue
  1) Create a new company
  2) Create a Lead for a customer with the Company set
  3) Remove the Sales Team
  4) Set the company on the Lead
  5) Convert to an opportunity and you will see an error showing up

Solution

A previous commit (1fad826) adapted the `_compute_company_id`
computation in which a case was forgotten (the case described here-above).
The fix was to force the `company_id` to the one of the `partner_id` if it
has one.

OPW-2805181
Task-2888330

closes odoo#88108

Signed-off-by: Thibault Delavallee (tde) <[email protected]>
X-original-commit: fc3bb66

Author: lade-odoo

addons/crm/models/crm_lead.py

@@ -272,7 +272,7 @@ def _compute_team_id(self):
             team = self.env['crm.team']._get_default_team_id(user_id=user.id, domain=team_domain)
             lead.team_id = team.id
 
-    @api.depends('user_id', 'team_id')
+    @api.depends('user_id', 'team_id', 'partner_id')
     def _compute_company_id(self):
         """ Compute company_id coherency. """
         for lead in self:
@@ -290,7 +290,9 @@ def _compute_company_id(self):
                 if lead.team_id and not lead.team_id.company_id and not lead.user_id:
                     proposal = False
                 # no user and no team -> void company and let assignment do its job
-                if not lead.team_id and not lead.user_id:
+                # unless customer has a company
+                if not lead.team_id and not lead.user_id and \
+                   (not lead.partner_id or lead.partner_id.company_id != proposal):
                     proposal = False
 
             # propose a new company based on responsible, limited by team
@@ -301,6 +303,8 @@ def _compute_company_id(self):
                     proposal = lead.user_id.company_id & self.env.companies
                 elif lead.team_id:
                     proposal = lead.team_id.company_id
+                elif lead.partner_id:
+                    proposal = lead.partner_id.company_id
                 else:
                     proposal = False
 

addons/test_crm_full/tests/test_performance.py

@@ -89,7 +89,7 @@ def test_lead_create_form_address(self):
     @warmup
     def test_lead_create_form_partner(self):
         """ Test a single lead creation using Form with a partner """
-        with freeze_time(self.reference_now), self.assertQueryCount(user_sales_leads=193):  # tcf only: 178 - com runbot: 179/180
+        with freeze_time(self.reference_now), self.assertQueryCount(user_sales_leads=197):  # tcf only: 178 - com runbot: 179/180
             self.env.cr._now = self.reference_now  # force create_date to check schedulers
             with Form(self.env['crm.lead']) as lead_form:
                 lead_form.partner_id = self.partners[0]