Skip to content

[IMP] Quality: Instructions check Shop Floor #6779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[IMP] Quality: Instructions check Shop Floor #6779

wants to merge 1 commit into from

Conversation

@hojo-odoo
Copy link
Contributor

@hojo-odoo hojo-odoo commented Dec 5, 2023

This PR replaces the tablet view workflow in the Instructions check doc with a new section detailing the workflow for the Shop Floor module.

@hojo-odoo hojo-odoo changed the base branch from saas-16.4 to 16.0 December 5, 2023 19:57
@hojo-odoo hojo-odoo changed the base branch from 16.0 to saas-16.4 December 5, 2023 19:58
@robodoo
Copy link
Collaborator

robodoo commented Dec 5, 2023

Pull request status dashboard.

@hojo-odoo hojo-odoo changed the base branch from saas-16.4 to 16.0 December 5, 2023 19:58
@hojo-odoo hojo-odoo changed the base branch from 16.0 to saas-16.4 December 5, 2023 19:58
@C3POdoo C3POdoo requested a review from a team December 5, 2023 20:00
Felicious
Felicious approved these changes Dec 26, 2023
View reviewed changes
Copy link
Contributor

@Felicious Felicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hojo-odoo, great job with updating this doc for 16.4+ 😁

The content accuracy and flow looks great, and I only had very minor formatting things to bring up, and after you address those, feel free to move this onto the next stage!

@Felicious Felicious mentioned this pull request Dec 26, 2023
Closed
@hojo-odoo hojo-odoo force-pushed the 16.4-mrp-instructions-check-shop-floor-hojo branch from db94286 to 12e65d3 Compare December 27, 2023 17:56
@hojo-odoo hojo-odoo requested a review from ksc-odoo December 27, 2023 17:59
ksc-odoo
ksc-odoo approved these changes Dec 27, 2023
View reviewed changes
Copy link
Contributor

@ksc-odoo ksc-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hojo-odoo Just completed my Peer Review on this doc. Great job! Just a few things that need your attention -- but once those are taken care of, this one should be ready for the next stage 👍

@hojo-odoo hojo-odoo force-pushed the 16.4-mrp-instructions-check-shop-floor-hojo branch from 12e65d3 to 6ee71b4 Compare January 16, 2024 18:46
@hojo-odoo hojo-odoo requested a review from a team January 17, 2024 20:40
ksc-odoo
ksc-odoo approved these changes Jan 18, 2024
View reviewed changes
Copy link
Contributor

@ksc-odoo ksc-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hojo-odoo just finished reviewing this doc. awesome job! just a couple, super-minor comments that'll need your attention. but, once those are addressed, I think this one will be ready for the Tech Review stage. Great work! 👍

@hojo-odoo hojo-odoo force-pushed the 16.4-mrp-instructions-check-shop-floor-hojo branch from 6ee71b4 to 375f361 Compare January 18, 2024 19:35
@hojo-odoo
Copy link
Contributor Author

hojo-odoo commented Jan 18, 2024

@samueljlieber This is ready for technical review.

@hojo-odoo hojo-odoo force-pushed the 16.4-mrp-instructions-check-shop-floor-hojo branch 2 times, most recently from 5cd24b1 to 48f5d15 Compare January 25, 2024 18:10
@hojo-odoo hojo-odoo changed the title [IMP] Add Instructions check doc Shop Floor content [IMP] Quality: Instructions check Shop Floor Jan 25, 2024
samueljlieber
samueljlieber approved these changes Jan 25, 2024
View reviewed changes
Copy link
Contributor

@samueljlieber samueljlieber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good to me @hojo-odoo, nice work!

@StraubCreative this PR is good to go 👍

StraubCreative
StraubCreative approved these changes Jan 26, 2024
View reviewed changes
Copy link
Contributor

@StraubCreative StraubCreative left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @hojo-odoo
LGTM 👍
I caught an early line break on line 13 and would prefer a seealso tag at the bottom of the doc. I'll push both up momentarily for merge.

Note: please quickly adjust this doc for 17.0 either on the FW PR that will result from merge, or on a new PR. This is to cover for the fact that there's no Open Shop Floor button beyond saas-16.4, thanks!

content/applications/inventory_and_mrp/quality/quality_check_types/instructions_check.rst
Comment on lines +96 to +98
.. note::
For a full guide to the *Shop Floor* module, see the :ref:`Shop Floor overview
<manufacturing/shop_floor/shop_floor_overview>` documentation.
Copy link
Contributor

@StraubCreative StraubCreative Jan 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.. note::
For a full guide to the *Shop Floor* module, see the :ref:`Shop Floor overview
<manufacturing/shop_floor/shop_floor_overview>` documentation.
.. seealso::
For a full guide to the *Shop Floor* module, see the :ref:`Shop Floor overview
<manufacturing/shop_floor/shop_floor_overview>` documentation.

@Felicious @ksc-odoo @StraubCreative
[IMP] Quality: Instructions check Shop Floor
107a4a6 
Co-authored-by: Felicious <[email protected]>
Co-authored-by: ksc-odoo <[email protected]>
Co-authored-by: StraubCreative <[email protected]>
@StraubCreative StraubCreative force-pushed the 16.4-mrp-instructions-check-shop-floor-hojo branch from 48f5d15 to 107a4a6 Compare January 26, 2024 02:36
@StraubCreative
Copy link
Contributor

StraubCreative commented Jan 26, 2024

@robodoo r+

robodoo pushed a commit that referenced this pull request Jan 26, 2024
@Felicious @ksc-odoo @StraubCreative
[IMP] Quality: Instructions check Shop Floor
58365b7 
closes #6779

Signed-off-by: Zachary Straub (zst) <[email protected]>
Co-authored-by: Felicious <[email protected]>
Co-authored-by: ksc-odoo <[email protected]>
Co-authored-by: StraubCreative <[email protected]>
@fw-bot fw-bot mentioned this pull request Jan 26, 2024
Closed
@robodoo robodoo closed this Jan 26, 2024
This was referenced Jan 26, 2024
Closed
Closed
@fw-bot
Copy link
Collaborator

fw-bot commented Jan 29, 2024

@hojo-odoo @StraubCreative this pull request has forward-port PRs awaiting action (not merged or closed):

@fw-bot
Copy link
Collaborator

fw-bot commented Jan 30, 2024

@hojo-odoo @StraubCreative this pull request has forward-port PRs awaiting action (not merged or closed):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StraubCreative StraubCreative StraubCreative approved these changes

@Felicious Felicious Felicious approved these changes

@samueljlieber samueljlieber samueljlieber approved these changes

+1 more reviewer

@ksc-odoo ksc-odoo ksc-odoo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@hojo-odoo @robodoo @StraubCreative @fw-bot @Felicious @samueljlieber @ksc-odoo