[IMP] Quality: Pass - Fail check Shop Floor #6781
Conversation
Felicious
left a comment
Felicious
left a comment
There was a problem hiding this comment.
Great job with this Shop Floor update, @hojo-odoo!! I just had minor comments on formatting. Everything looked good when I tested the flow!
content/applications/inventory_and_mrp/quality/quality_check_types/pass_fail_check.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/quality/quality_check_types/pass_fail_check.rst
Show resolved
Hide resolved
ksc-odoo
left a comment
ksc-odoo
left a comment
There was a problem hiding this comment.
Alrighty @hojo-odoo Just finished my Peer Review of this doc, and apart from a couple SUPER-MINOR adjustments, I think this one is ready to move on to the next stage. Once those little changes are addressed, it should be good-to-go 👍
content/applications/inventory_and_mrp/quality/quality_check_types/pass_fail_check.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/quality/quality_check_types/pass_fail_check.rst
Show resolved
Hide resolved
content/applications/inventory_and_mrp/quality/quality_check_types/pass_fail_check.rst
Outdated
Show resolved
Hide resolved
hojo-odoo
force-pushed
the
16.4-mrp-pass-fail-check-shop-floor-hojo
branch
from
0c7c30a to
a7cae60
Compare
ksc-odoo
left a comment
ksc-odoo
left a comment
There was a problem hiding this comment.
@hojo-odoo Just finished my review. another great doc (as usual) 👍 once you address the very minor comments that I left, this one should be ready to move to the Tech Review stage. Awesome job!
content/applications/inventory_and_mrp/quality/quality_check_types/pass_fail_check.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/quality/quality_check_types/pass_fail_check.rst
Show resolved
Hide resolved
content/applications/inventory_and_mrp/quality/quality_check_types/pass_fail_check.rst
Outdated
Show resolved
Hide resolved
hojo-odoo
force-pushed
the
16.4-mrp-pass-fail-check-shop-floor-hojo
branch
from
a7cae60 to
68e6704
Compare
|
@samueljlieber This is ready for technical review. |
samueljlieber
left a comment
samueljlieber
left a comment
There was a problem hiding this comment.
Looks good to me @hojo-odoo! Nice job on the improvements in this PR.
I have only one correction, and it is to the commit tag & PR title, please update it to follow the naming convention as well as make it a bit shorter/concise, something like:
[IMP] quality: pass-fail check shop floor
I am approving now, but please update the commit tag & PR title before tagging for merge 🙂
hojo-odoo
force-pushed
the
16.4-mrp-pass-fail-check-shop-floor-hojo
branch
from
68e6704 to
6d084da
Compare
hojo-odoo
changed the title
StraubCreative
left a comment
StraubCreative
left a comment
There was a problem hiding this comment.
hi @hojo-odoo
approving with a couple comments below
please address the icon name and consider using the admonition block at the end
@robodoo delegate=hojo-odoo
content/applications/inventory_and_mrp/quality/quality_check_types/pass_fail_check.rst
Show resolved
Hide resolved
content/applications/inventory_and_mrp/quality/quality_check_types/pass_fail_check.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/quality/quality_check_types/pass_fail_check.rst
Outdated
Show resolved
Hide resolved
hojo-odoo
force-pushed
the
16.4-mrp-pass-fail-check-shop-floor-hojo
branch
from
6d084da to
2f56dc6
Compare
|
@robodoo r+ |
closes #6781 Signed-off-by: John Holton (hojo) <[email protected]>
|
@hojo-odoo this pull request has forward-port PRs awaiting action (not merged or closed): |
3 similar comments
|
@hojo-odoo this pull request has forward-port PRs awaiting action (not merged or closed): |
|
@hojo-odoo this pull request has forward-port PRs awaiting action (not merged or closed): |
|
@hojo-odoo this pull request has forward-port PRs awaiting action (not merged or closed): |
|
@hojo-odoo this pull request has forward-port PRs awaiting action (not merged or closed): |
2 similar comments
|
@hojo-odoo this pull request has forward-port PRs awaiting action (not merged or closed): |
|
@hojo-odoo this pull request has forward-port PRs awaiting action (not merged or closed): |
This PR replaces the tablet view workflow in the Pass - Fail check doc with a new section detailing the workflow for the Shop Floor module.