Skip to content

Conversation

@jero-odoo
Copy link
Contributor

Updated content and images for 15.0

@jero-odoo jero-odoo self-assigned this Sep 21, 2023
@robodoo
Copy link
Collaborator

robodoo commented Sep 21, 2023

@jero-odoo jero-odoo requested a review from a team September 21, 2023 17:58
@jero-odoo
Copy link
Contributor Author

@ksc-odoo , @meng-odoo Can one of you do a first round review on this? Thanks!

@ksc-odoo
Copy link
Contributor

@ksc-odoo , @meng-odoo Can one of you do a first round review on this? Thanks!

Sure! I'll give it a look right now!

Copy link
Contributor

@ksc-odoo ksc-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jero-odoo hey there! Just finished my review of this doc. Great work! My suggestions are mainly focused on some elaboration in certain instances, along with some potential supplemental screenshots that could round out this doc. Also, feel free to tag me for any future CRM docs you do - I'd be happy to help out with reviews. Thanks again for all your awesome work! 👍

@jero-odoo jero-odoo force-pushed the 15.0-CRM-update-manage-lost-opps-jero branch from d451c87 to dd8ebde Compare September 25, 2023 15:50
@jero-odoo
Copy link
Contributor Author

Thank you @ksc-odoo ! Tagging in the inventory team for a second round.

@jero-odoo jero-odoo requested a review from a team September 25, 2023 15:54
Copy link
Contributor

@brse-odoo brse-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jero-odoo, I've finished my review of this doc. Great job! I had a small number of suggestions for you to accept/reject as you see fit. Let me know if you have any questions. Thanks!

@jero-odoo jero-odoo force-pushed the 15.0-CRM-update-manage-lost-opps-jero branch from 153a119 to 4999ff5 Compare October 3, 2023 14:03
@jero-odoo
Copy link
Contributor Author

Thank you @brse-odoo !
Sending to @odoo/us-doc-review 👍

@jero-odoo jero-odoo requested a review from a team October 3, 2023 14:06
@jero-odoo
Copy link
Contributor Author

@ksc-odoo and @brse-odoo can you approve the changes before I send to final? Thank you!

Copy link
Contributor

@ksc-odoo ksc-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of minor adjustments that'll need your quick attention, but once those are taken care of, I think you can move this to the next stage. Great job! 👍

@jero-odoo jero-odoo force-pushed the 15.0-CRM-update-manage-lost-opps-jero branch from ccad2ce to d477daa Compare October 25, 2023 13:59
@jero-odoo
Copy link
Contributor Author

Thank you! Ready for @odoo/us-doc-review

Copy link
Contributor

@samueljlieber samueljlieber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jero-odoo, great work on this PR! I have a couple technical changes after my review, please see below:

Please update the commit tag to follow the convention, "IMP crm: ..." ➡️ "[IMP] crm: ..."

Tag again for a final look after these changes have been addressed, thank you! 🙏

Co-authored-by: ksc-odoo <[email protected]>

Co-authored-by: brse-odoo <[email protected]>

Co-authored-by: Sam Lieber (sali) <[email protected]>
@jero-odoo jero-odoo force-pushed the 15.0-CRM-update-manage-lost-opps-jero branch from a320efd to 435b5b1 Compare November 27, 2023 14:01
@jero-odoo
Copy link
Contributor Author

Updated @samueljlieber ! Thanks!

Copy link
Contributor

@StraubCreative StraubCreative left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @jero-odoo 👍
@robodoo r+

robodoo pushed a commit that referenced this pull request Nov 27, 2023
closes #5888

Signed-off-by: Zachary Straub (zst) <[email protected]>
Co-authored-by: ksc-odoo <[email protected]>
Co-authored-by: brse-odoo <[email protected]>
Co-authored-by: Sam Lieber (sali) <[email protected]>
@robodoo robodoo closed this Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants