-
Notifications
You must be signed in to change notification settings - Fork 10.6k
[IMP] crm: update manage lost opps #5888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@ksc-odoo , @meng-odoo Can one of you do a first round review on this? Thanks! |
Sure! I'll give it a look right now! |
ksc-odoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jero-odoo hey there! Just finished my review of this doc. Great work! My suggestions are mainly focused on some elaboration in certain instances, along with some potential supplemental screenshots that could round out this doc. Also, feel free to tag me for any future CRM docs you do - I'd be happy to help out with reviews. Thanks again for all your awesome work! 👍
d451c87 to
dd8ebde
Compare
|
Thank you @ksc-odoo ! Tagging in the inventory team for a second round. |
brse-odoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jero-odoo, I've finished my review of this doc. Great job! I had a small number of suggestions for you to accept/reject as you see fit. Let me know if you have any questions. Thanks!
153a119 to
4999ff5
Compare
|
Thank you @brse-odoo ! |
|
@ksc-odoo and @brse-odoo can you approve the changes before I send to final? Thank you! |
ksc-odoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of minor adjustments that'll need your quick attention, but once those are taken care of, I think you can move this to the next stage. Great job! 👍
ccad2ce to
d477daa
Compare
|
Thank you! Ready for @odoo/us-doc-review |
samueljlieber
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jero-odoo, great work on this PR! I have a couple technical changes after my review, please see below:
Please update the commit tag to follow the convention, "IMP crm: ..." ➡️ "[IMP] crm: ..."
Tag again for a final look after these changes have been addressed, thank you! 🙏
Co-authored-by: ksc-odoo <[email protected]> Co-authored-by: brse-odoo <[email protected]> Co-authored-by: Sam Lieber (sali) <[email protected]>
a320efd to
435b5b1
Compare
|
Updated @samueljlieber ! Thanks! |
StraubCreative
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks @jero-odoo 👍
@robodoo r+
closes #5888 Signed-off-by: Zachary Straub (zst) <[email protected]> Co-authored-by: ksc-odoo <[email protected]> Co-authored-by: brse-odoo <[email protected]> Co-authored-by: Sam Lieber (sali) <[email protected]>
Updated content and images for 15.0