[FW][IMP] odoo_theme: introduce fallback URLs for the page switchers #2047
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a user clicks on the link of an alternate page in the version or language switcher, we now check if the page referenced by the target URL exists or not. If not, we generate a series of fallback URLs from the target URL and check whether the targeted resource exists or not, until we read the root of the documentation. As soon as we find a valid URL, we redirect the user to it. This is inspired by the behaviour of docs.python.org's version and language switchers. task-2534669 X-original-commit: 25e863a Co-authored-by: Antoine Vandevenne (anv) <[email protected]>
Collaborator
Collaborator
Author
|
This PR targets saas-15.1 and is part of the forward-port chain. Further PRs will be created up to master. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
robodoo
pushed a commit
that referenced
this pull request
May 19, 2022
When a user clicks on the link of an alternate page in the version or language switcher, we now check if the page referenced by the target URL exists or not. If not, we generate a series of fallback URLs from the target URL and check whether the targeted resource exists or not, until we read the root of the documentation. As soon as we find a valid URL, we redirect the user to it. This is inspired by the behaviour of docs.python.org's version and language switchers. task-2534669 closes #2047 X-original-commit: 25e863a Signed-off-by: Antoine Vandevenne (anv) <[email protected]> Signed-off-by: Martin Trigaux (mat) <[email protected]> Co-authored-by: Antoine Vandevenne (anv) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a user clicks on the link of an alternate page in the version or
language switcher, we now check if the page referenced by the target URL
exists or not. If not, we generate a series of fallback URLs from the
target URL and check whether the targeted resource exists or not, until
we read the root of the documentation. As soon as we find a valid URL,
we redirect the user to it.
This is inspired by the behaviour of docs.python.org's version and
language switchers.
task-2534669
Forward-Port-Of: #1588