[IMP] odoo_theme: introduce fallback URLs for the page switchers #1588
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
mart-e
force-pushed
the
13.0-fallback-urls-switcher-mat
branch
4 times, most recently
from
d258bea to
70fe30d
Compare
Collaborator
|
Sorry, I didn't know about this PR and had to retrieve its information, you may have to re-approve it. |
Collaborator
mart-e
force-pushed
the
13.0-fallback-urls-switcher-mat
branch
2 times, most recently
from
96c1bb4 to
9dc83a6
Compare
mart-e
force-pushed
the
13.0-fallback-urls-switcher-mat
branch
2 times, most recently
from
689475c to
80f8f6b
Compare
mart-e
changed the title
AntoineVDV
force-pushed
the
13.0-fallback-urls-switcher-mat
branch
from
80f8f6b to
fb87d9e
Compare
AntoineVDV
changed the title
AntoineVDV
force-pushed
the
13.0-fallback-urls-switcher-mat
branch
from
fb87d9e to
d048576
Compare
AntoineVDV
force-pushed
the
13.0-fallback-urls-switcher-mat
branch
3 times, most recently
from
2c88104 to
b720612
Compare
When a user clicks on the link of an alternate page in the version or language switcher, we now check if the page referenced by the target URL exists or not. If not, we generate a series of fallback URLs from the target URL and check whether the targeted resource exists or not, until we read the root of the documentation. As soon as we find a valid URL, we redirect the user to it. This is inspired by the behaviour of docs.python.org's version and language switchers. task-2534669 Co-authored-by: Antoine Vandevenne (anv) <[email protected]>
AntoineVDV
force-pushed
the
13.0-fallback-urls-switcher-mat
branch
from
b720612 to
074c91f
Compare
robodoo
pushed a commit
that referenced
this pull request
May 19, 2022
When a user clicks on the link of an alternate page in the version or language switcher, we now check if the page referenced by the target URL exists or not. If not, we generate a series of fallback URLs from the target URL and check whether the targeted resource exists or not, until we read the root of the documentation. As soon as we find a valid URL, we redirect the user to it. This is inspired by the behaviour of docs.python.org's version and language switchers. task-2534669 closes #1588 Signed-off-by: Antoine Vandevenne (anv) <[email protected]> Co-authored-by: Antoine Vandevenne (anv) <[email protected]>
This was referenced May 19, 2022
This was referenced May 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a user clicks on the link of an alternate page in the version or
language switcher, we now check if the page referenced by the target URL
exists or not. If not, we generate a series of fallback URLs from the
target URL and check whether the targeted resource exists or not, until
we read the root of the documentation. As soon as we find a valid URL,
we redirect the user to it.
This is inspired by the behaviour of docs.python.org's version and
language switchers.
task-2534669