patch sequence page #1205

c-cube · 2023-05-22T15:11:50Z

No description provided.

cuihtlauac · 2023-05-22T15:19:55Z

Thanks @c-cube, am I correct assuming this only about the Sequences documentation and the other files went in this PR accidentally?

sabine · 2023-05-22T15:33:34Z

This might be the state of staging at the time.

c-cube · 2023-05-22T15:35:38Z

Ok I have no idea what's going on there. I edited from the "contribute" button on the website (URL: https://github.com/ocaml/ocaml.org/blob/c461890f0ce6473bd4faf55b1d7157c1000e0fcb/data/tutorials/ds_05_seq.md) and ended up on a detached commit?

sabine · 2023-05-22T15:39:08Z

Sorry about that, the contribute link goes to the commit on the staging branch.

c-cube · 2023-05-22T15:39:15Z

if someone wants to cherry pick the small change… :)

sabine · 2023-05-22T15:40:29Z

So the diff with staging instead of main is going to be much better. 🙂

No worries, we will take it from here.

c-cube · 2023-05-22T15:42:27Z

Thanks y'all :)

cuihtlauac · 2023-05-22T16:57:49Z

I've updated #791 with what seemed unique to this PR. Changes had taken place in parallel there. Reconciliation was needed. I hope I haven't lost any of your suggestions in the process.

Thanks again for your feedback, and apologizes for the unpleasant review experience.

staging is up to date w.r.t. #791

c-cube · 2023-05-22T17:09:25Z

I don't think you lost anything! If anything you attributed too many things to me in the last commit 😅 . I'm closing this.

No worries for the reviewing experience, it's never easy to make this kind of things smooth. Cheers!

christinerose

Mostly minor grammar/formatting fixes. Tightened some syntax and found a few typos.

christinerose · 2023-05-22T16:19:38Z

data/tutorials/ds_05_seq.md

+function returning a sequence while its `list` counterpart returns a list. Let's
+compare the constructors of `list` and `Seq.node`:
+1. Empty lists and sequences are defined the same way, a constructor without any
+   parameter: `Seq.Nil` and `[]`.


Suggested change

parameter: `Seq.Nil` and `[]`.

parameters: `Seq.Nil` and `[]`.

christinerose · 2023-05-22T16:20:48Z

data/tutorials/ds_05_seq.md

+```ocaml
+# Seq.iter print_int (ints 0);;
+```
+in an OCaml top-level means “print integers forever,” and you have to press


Suggested change

in an OCaml top-level means “print integers forever,” and you have to press

in an OCaml toplevel means “print integers forever,” and you have to press

christinerose · 2023-05-22T16:21:59Z

data/tutorials/ds_05_seq.md

+The function `sieve` is recursive in OCaml and common sense. It is defined using
+the `rec` keyword and calls itself. However, some call that kind of function
+[_corecursive_](https://en.wikipedia.org/wiki/Corecursion). This word is used to
+emphasize that, by design, it does not terminate. Strictly speaking, the sieve


Suggested change

emphasize that, by design, it does not terminate. Strictly speaking, the sieve

emphasise that, by design, it does not terminate. Strictly speaking, the sieve

christinerose · 2023-05-22T16:24:56Z

data/tutorials/ds_05_seq.md

+* Sequence consumer: partially applied function parameter
+* Sequence producer: partially applied function result
+
+When code dealing with sequences does not behave as expected like if it is


Suggested change

When code dealing with sequences does not behave as expected like if it is

When code dealing with sequences does not behave as expected, like if it is

christinerose · 2023-05-22T16:25:23Z

data/tutorials/ds_05_seq.md

+  val String.of_seq : string -> char Seq.t
+  val String.to_seq : char Seq.t -> string
+  ```
+Similar functions are also provided for sets, maps, hash tables (`Hashtbl`) and


Suggested change

Similar functions are also provided for sets, maps, hash tables (`Hashtbl`) and

Similar functions are also provided for sets, maps, hash tables, (`Hashtbl`) and

christinerose · 2023-05-22T17:14:16Z