Skip to content

Conversation

@cuihtlauac
Copy link
Collaborator

@cuihtlauac cuihtlauac commented Jan 12, 2023

An attempt at describing sequences to beginners.
Online in staging: https://staging.ocaml.org/docs/sequences (with some lag)

@cuihtlauac cuihtlauac marked this pull request as draft January 12, 2023 09:17
@cuihtlauac cuihtlauac changed the title A Data-Type Document on Sequences Documentation: Sequences Jan 12, 2023
Copy link
Contributor

@christinerose christinerose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly minor grammar stuff, but there is one section that needs some clarification. I left some questions.

@cuihtlauac cuihtlauac marked this pull request as ready for review February 3, 2023 16:27
Copy link
Contributor

@christinerose christinerose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few questions for some clarification. Most everything else was grammar/syntax suggestions. Looking forward to working on it some more!

@cuihtlauac
Copy link
Collaborator Author

I left a few questions for some clarification. Most everything else was grammar/syntax suggestions. Looking forward to working on it some more!

Thank you very much, @christinerose; this is so helpful. It's such a pleasure to add your corrections; I love it.

@christinerose
Copy link
Contributor

I left a few questions for some clarification. Most everything else was grammar/syntax suggestions. Looking forward to working on it some more!

Thank you very much, @christinerose; this is so helpful. It's such a pleasure to add your corrections; I love it.

Aw! This made my day! Thank you so much for saying so. It’s a pleasure for me, too. 😊

@cuihtlauac cuihtlauac mentioned this pull request Feb 28, 2023
18 tasks
@cuihtlauac cuihtlauac changed the title Documentation: Sequences New Documentation: Sequences Feb 28, 2023
@cuihtlauac cuihtlauac changed the title New Documentation: Sequences Documentation: Sequences Feb 28, 2023
cuihtlauac pushed a commit that referenced this pull request May 4, 2023
Copy link
Contributor

@christinerose christinerose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestions :)

cuihtlauac pushed a commit that referenced this pull request May 5, 2023
sabine added a commit that referenced this pull request May 22, 2023
Commit 5305db6
Author: Cuihtlauac ALVARADO <[email protected]>

    Some more edits
sabine added a commit that referenced this pull request May 22, 2023
Commit 5305db6
Author: Cuihtlauac ALVARADO <[email protected]>

    Some more edits
# Seq.iter print_int (ints 0);;
```
in an OCaml toplevel, this means “print integers forever,” and you have to press
in an OCaml top-level, this means “print integers forever,” and you have to press
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
in an OCaml top-level, this means “print integers forever,” and you have to press
in an OCaml toplevel, this means “print integers forever,” and you have to press

no hyphen is correct in toplevel when speaking of OCaml's toplevel.

@sabine sabine merged commit d731046 into main May 30, 2023
@sabine sabine deleted the add-seq-doc branch May 30, 2023 17:16
@tmattio tmattio mentioned this pull request Jul 19, 2023
@tmattio
Copy link
Collaborator

tmattio commented Jul 19, 2023

Closes #791

@tmattio tmattio linked an issue Jul 19, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sequences

7 participants