Skip to content

fix: do not translate OpenJS trademark #6847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 19, 2024
Merged

fix: do not translate OpenJS trademark #6847

merged 1 commit into from
Jun 19, 2024

Conversation

@bmuenzenmeyer
Copy link
Contributor

Description

Per a Slack conversation and OpenJS Guidance - do not translate.

Validation

View the site in other locales

Related Issues

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npm run format to ensure the code follows the style guide.
  • I have run npm run test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

@bmuenzenmeyer bmuenzenmeyer requested a review from a team as a code owner June 19, 2024 04:30
@vercel
Copy link

vercel bot commented Jun 19, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Jun 19, 2024 4:31am

@github-actions
Copy link
Contributor

Note

Your Pull Request seems to be updating Translations of the Node.js Website.

Whilst we appreciate your intent; Any Translation update should be done through our Crowdin Project.
We recommend giving a read on our Translation Guidelines.

Thank you!

@bmuenzenmeyer bmuenzenmeyer requested a review from kyliewd June 19, 2024 04:31
AugustinMauroy
AugustinMauroy approved these changes Jun 19, 2024
View reviewed changes
Copy link
Member

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT !

@ovflowd ovflowd added the fast-track Fast Tracking PRs label Jun 19, 2024
@ovflowd
Copy link
Member

ovflowd commented Jun 19, 2024

Fast Tracking this PR

@ovflowd ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Jun 19, 2024
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Jun 19, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Jun 19, 2024 •
edited
Loading

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 99 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 99 🟢 100 🟢 100 🟢 91 🔗
/en/about/previous-releases 🟢 98 🟢 100 🟢 100 🟢 92 🔗
/en/download 🟢 99 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 99 🟢 100 🟢 100 🟢 92 🔗

@ovflowd ovflowd enabled auto-merge June 19, 2024 12:43
@github-actions
Copy link
Contributor

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 92%
 90.67% (593/654) 76.08% (175/230) 94.57% (122/129)

Unit Test Report

Tests Skipped Failures Errors Time
131 0 💤 0 ❌ 0 🔥 5.244s ⏱️

@ovflowd ovflowd added this pull request to the merge queue Jun 19, 2024
Merged via the queue into main with commit 10887a9 Jun 19, 2024
@ovflowd ovflowd deleted the openjs-trademark branch June 19, 2024 12:50
@bmuenzenmeyer bmuenzenmeyer mentioned this pull request Jul 31, 2024
Closed
@bmuenzenmeyer bmuenzenmeyer mentioned this pull request Aug 12, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ovflowd ovflowd ovflowd approved these changes

@AugustinMauroy AugustinMauroy AugustinMauroy approved these changes

@kyliewd kyliewd Awaiting requested review from kyliewd

Assignees

No one assigned

Labels

fast-track Fast Tracking PRs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bmuenzenmeyer @ovflowd @AugustinMauroy