Skip to content

Translation CI Check Needs To Trigger on Forks #6954

@bmuenzenmeyer

Description

@bmuenzenmeyer

github.event.pull_request.head.repo.full_name == 'nodejs/nodejs.org' &&
references the head being nodejs/nodejs.org which will only ever be true for contributors with push access.

I think the vastly more common scenario is when someone forks the repo and tries making a change, like in #6952 (bad that it didnt provide feedback) - notice how our warning did not give the contributor feedback there, but it did for my contributor PR #6847 (bad that it tripped for us, we should have noticed).

IMO, the logic should instead be:

    # This comment should always be posted on forks, or from internal PRs not originating from Crowdin (which are direct branches)
    if: |
      (github.event.pull_request.head.repo.full_name != 'nodejs/nodejs.org') ||
      (github.event.pull_request.head.repo.full_name == 'nodejs/nodejs.org' && github.event.pull_request.head.ref != 'chore/crowdin')

Metadata

Metadata

Assignees

No one assigned

    Labels

    infrastructureIssues/PRs related to the Repository Infra

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions