Add IBM i to package manager page #2223
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
marked this pull request as ready for review
srl295
approved these changes
May 9, 2019
Member
|
LGTM |
aymen94
approved these changes
May 9, 2019
added 4 commits
May 10, 2019 11:06
zh-CN: translation of "IBM i"
zh-CN: Fix the Italic Words
zh-TW：translation of "IBM i"
en: Fix the Italic Words
|
@nodejs/website：Please have a translation if possible for this, thanks anyway! |
zh-CN：add the missing English origin
zh-CN：Fix the translation error
Contributor
|
It seems that But |
Contributor
|
@nodejs/nodejs-ko Updated Korean translation. Please take a look. |
en: use '\' in front of '*'
zh-CN：add '\' in front of '*'
zh-CN: remove '*'
Aissaoui-Ahmed
approved these changes
May 11, 2019
Contributor
|
Update |
celyes
suggested changes
May 11, 2019
celyes
approved these changes
May 11, 2019
Contributor
There was a problem hiding this comment.
Looks great
thank you all @ThePrez @Aissaoui-Ahmed @Maledong @aymen94 @ouadie-lahdioui @mhdawson
|
Thank you all! |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening as a draft, as I figure it makes sense to "land" this when Node 12 is available from IBM (but am willing to take feedback in the meantime).