lib: flag to conditionally modify proto on deprecate #58928
Merged
+53
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refs: nodejs#58218 Signed-off-by: RafaelGSS <[email protected]>
|
Review requested:
|
nodejs-github-bot
added
needs-ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #58928 +/- ##
==========================================
- Coverage 90.11% 90.07% -0.04%
==========================================
Files 640 640
Lines 188427 188466 +39
Branches 36956 36969 +13
==========================================
- Hits 169792 169765 -27
- Misses 11348 11426 +78
+ Partials 7287 7275 -12
🚀 New features to boost your workflow:
|
RafaelGSS
added
help wanted
juanarbol
approved these changes
Jul 7, 2025
RafaelGSS
added
author ready
nodejs-github-bot
removed
the
commit-queue
Commit Queue failed- Loading data for nodejs/node/pull/58928 ✔ Done loading data for nodejs/node/pull/58928 ----------------------------------- PR info ------------------------------------ Title lib: flag to conditionally modify proto on deprecate (#58928) Author Rafael Gonzaga <[email protected]> (@RafaelGSS) Branch RafaelGSS:conditionally-modify-prototype-deprecate -> nodejs:main Labels util, author ready, needs-ci, review wanted Commits 1 - lib: flag to conditionally modify proto on deprecate Committers 1 - RafaelGSS <[email protected]> PR-URL: https://github.com/nodejs/node/pull/58928 Refs: https://github.com/nodejs/node/issues/58218 Reviewed-By: Juan José Arboleda <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/58928 Refs: https://github.com/nodejs/node/issues/58218 Reviewed-By: Juan José Arboleda <[email protected]> -------------------------------------------------------------------------------- ℹ This PR was created on Wed, 02 Jul 2025 14:55:12 GMT ✔ Approvals: 1 ✔ - Juan José Arboleda (@juanarbol): https://github.com/nodejs/node/pull/58928#pullrequestreview-2995063544 ✘ This PR needs to wait 25 more hours to land (or 0 hours if there is one more approval) ✔ Last GitHub CI successful ℹ Last Full PR CI on 2025-07-03T19:58:05Z: https://ci.nodejs.org/job/node-test-pull-request/67827/ - Querying data for job/node-test-pull-request/67827/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/16145176087 |
nodejs-github-bot
added
the
commit-queue-failed
RafaelGSS
removed
the
commit-queue-failed
UlisesGascon
approved these changes
Jul 8, 2025
RafaelGSS
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in eff504f |
targos
pushed a commit
that referenced
this pull request
Jul 17, 2025
Refs: #58218 Signed-off-by: RafaelGSS <[email protected]> PR-URL: #58928 Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Ulises Gascón <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #58218
In this specific benchmark, the performance difference between
modifyPrototype=0andmodifyPrototype=1is marginally significant at the 5% level:While this case is borderline, other benchmarks (e.g., #58907) have shown a more noticeable improvement, so I think this worth the change.