src: use FastStringKey for TrackV8FastApiCall
#59148
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it easier to avoid unintentional mis-usage of the API.
This is the exact intended use case of `FastStringKey`.
nodejs-github-bot
added
c++
jasnell
approved these changes
Jul 21, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #59148 +/- ##
==========================================
- Coverage 90.05% 90.04% -0.01%
==========================================
Files 645 648 +3
Lines 189153 190986 +1833
Branches 37093 37440 +347
==========================================
+ Hits 170339 171979 +1640
- Misses 11518 11625 +107
- Partials 7296 7382 +86
🚀 New features to boost your workflow:
|
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
juanarbol
approved these changes
Jul 21, 2025
daeyeon
approved these changes
Jul 21, 2025
This comment was marked as outdated.
This comment was marked as outdated.
IlyasShabi
approved these changes
Jul 22, 2025
addaleax
added
the
author ready
jasnell
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 4b289d0...6bb08f7 |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Jul 23, 2025
This makes it easier to avoid unintentional mis-usage of the API. PR-URL: #59148 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Daeyeon Jeong <[email protected]> Reviewed-By: Ilyas Shabi <[email protected]>
nodejs-github-bot
pushed a commit
that referenced
this pull request
Jul 23, 2025
This is the exact intended use case of `FastStringKey`. PR-URL: #59148 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Daeyeon Jeong <[email protected]> Reviewed-By: Ilyas Shabi <[email protected]>
aduh95
pushed a commit
that referenced
this pull request
Jul 25, 2025
This makes it easier to avoid unintentional mis-usage of the API. PR-URL: #59148 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Daeyeon Jeong <[email protected]> Reviewed-By: Ilyas Shabi <[email protected]>
aduh95
pushed a commit
that referenced
this pull request
Jul 25, 2025
This is the exact intended use case of `FastStringKey`. PR-URL: #59148 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Daeyeon Jeong <[email protected]> Reviewed-By: Ilyas Shabi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
src: use C++20
constevalforFastStringKeyThis makes it easier to avoid unintentional mis-usage of the API.
src: use
FastStringKeyforTrackV8FastApiCallThis is the exact intended use case of
FastStringKey.