Convert Request, Response, CodeResponseType, TokenResponseType to ES6 classes #225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorenvandeweyer
requested changes
Aug 26, 2023
Member
jorenvandeweyer
left a comment
jorenvandeweyer
left a comment
There was a problem hiding this comment.
@menewman I got some small comments, could you please update these?
@jankapunkt PR seems fine. Could you also review this so this one can be merged?
12 tasks
jankapunkt
requested changes
Aug 26, 2023
Member
jankapunkt
left a comment
jankapunkt
left a comment
There was a problem hiding this comment.
There are some minor changes but I think at keast to has own property checks should be considered, even if the attack surface is rather superficial and imaginary
jorenvandeweyer
approved these changes
Aug 26, 2023
jankapunkt
approved these changes
Aug 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Chipping away at #212 by converting four more classes:
(Do note that TokenResponseType's constructor simply throws a not implemented error, though. So that conversion was easy. 😉)
Linked issue(s)
A few checkboxes of #212 (but not the whole thing).
Involved parts of the project
Specifically the classes noted above, which affect pretty much everything (since Request/Response are core parts of the interface). But, there are no functional changes.
Added tests?
I did not update the tests, but these files are already covered under the existing tests, which should continue to pass after this refactoring.
OAuth2 standard
N/A
Reproduction
N/A