Release 5.0.0

[jankapunkt]

Summary

Release 5.0.0

Added tests?

• update tests in https://github.com/node-oauth/express-oauth-server,
  because the CI actually runs extra tests in this package on release-* branches

[jankapunkt]

The CI fails, because https://github.com/node-oauth/express-oauth-server tests fail (in tests for release) so we need to update this repo, too.

[jankapunkt]

Released v5.0.0-rc.1

[jankapunkt]

@jorenvandeweyer thanks for the review, I will wait a few more days to see if anyone reports issues with the RC. Maybe until end of next week or rather end of the month?

[jankapunkt]

This is blocked until #219 is properly covered

[jankapunkt]

@jorenvandeweyer @shrihari-prakash RC5 is out: https://github.com/node-oauth/node-oauth2-server/releases/tag/v5.0.0-rc.5

[jorenvandeweyer]

Nice! I propose we release v5 in the week of 6 november?

I'm seeing a lot of download on the rc.4 version.

[jankapunkt]

Yes! Let's fix the 6th as release date

[shrihari-prakash]

On my side, no issues in my production apps since rc5 upgrade so far. Things have been pretty good ever since rc4!

[jankapunkt]

@jorenvandeweyer @shrihari-prakash I generated documentation for 5.0.0 including a little migration guide here: https://node-oauthoauth2-server.readthedocs.io/en/release-5.0.0/index.html

Please review it and let me know if it's all good then I will publish 5.0.0 today.

[shrihari-prakash]

@jankapunkt on my side, I see only 2.x to 3.x migration. Is this normal?

[shrihari-prakash]

Also, I don't know much about how read the docs works, but is the TOC supposed to show only the current section we are reading?

Isn't this difficult to navigate?

[jankapunkt]

So the link should be fixed. Regarding the navigation I found that read the docs changed their config model and the previous theme is not available anymore without adding tons of more config (requirements files, project.toml). I can look for a different theme but it should be builtin

[jankapunkt]

@shrihari-prakash the old theme is active now

[shrihari-prakash]

Looks perfect now! @jankapunkt . Ok with the content as well.

[jankapunkt]

@jorenvandeweyer @shrihari-prakash I finally published 5.0.0 🎉

[shrihari-prakash]

@jankapunkt still don't see it yet?

[jankapunkt]

It's on NPM released, the GitHub release is waiting until I have merged it into master