chore: update CODEOWNERS to match all nested paths #378
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eduardoboucas
approved these changes
Jul 22, 2025
pieh
added a commit
that referenced
this pull request
Jul 22, 2025
eduardoboucas
pushed a commit
that referenced
this pull request
Jul 22, 2025
* test: add test for function returning 304 response * test: run tests in dev dir * fix: maintain bodyless responses * test: enable watch mode in tests that test modifying functions * chore: update CODEOWNERS to match all nested paths (#378) * refactor: prefer early bails, use Set for more performant lookups
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #376 making changes to files in
packages/nuxt-module/test/and review being requested from runtime team where it should be frameworksAlso per https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners#codeowners-syntax our current syntax matches this example:
I'm not sure proposed change is fully correct, just that current one doesn't seem correct