chore: fix @netlify/nuxt flakes due to HMR port conflict
#376
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serhalp
force-pushed
the
serhalp/frb-1943-fix-ci-flakes-in-netlifyprimitives
branch
from
5b258e3 to
247affc
Compare
The nuxt module tests run the module in dev mode (because that's the point of our nuxt module), which results in HMR being enabled. Unlike the main vite port, there's no dynamic port selection for the HMR WebSocket port, so when the test files run in parallel they often conflict by trying to bind to the same port. I could harcode two different ports with `vite.server.hmr.port`, but there's very little value to exercising the HMR code path with these tests, so I just disabled it. See also very similar withastro/astro#11744.
serhalp
force-pushed
the
serhalp/frb-1943-fix-ci-flakes-in-netlifyprimitives
branch
from
247affc to
7f27bc5
Compare
pieh
approved these changes
Jul 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The nuxt module tests run the module in dev mode (because that's the point of our nuxt module), which results in HMR being enabled. Unlike the main vite port, there's no dynamic port selection for the HMR WebSocket port, so when the test files run in parallel they often conflict by trying to bind to the same port.
I could harcode two different ports with
vite.server.hmr.port, but there's very little value to exercising the HMR code path with these tests, so I just disabled it.See very similar Astro testing issue similarly resolved by vitejs/vite#16219.