This repository was archived by the owner on Oct 10, 2022. It is now read-only.
Add eslint-config-node
#211
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehmicky
added
the
type: chore
ehmicky
commented
Dec 8, 2020
| matrix: | ||
| os: [ubuntu-latest, macOS-latest, windows-latest] | ||
| node-version: [8.3.0, 14] | ||
| node-version: [8.17.0, 14.x] |
Contributor
Author
There was a problem hiding this comment.
Align with Netlify Build. We're also removing Node 8 support soon.
ehmicky
commented
Dec 8, 2020
| const client = new NetlifyAPI('1234myAccessToken') | ||
| const sites = await client.listSites() | ||
| return sites | ||
| } |
Contributor
Author
There was a problem hiding this comment.
Top-level await still confuses ESLint.
ehmicky
commented
Dec 8, 2020
|
|
||
| ```js | ||
| { | ||
| const opts = { |
Contributor
Author
There was a problem hiding this comment.
Otherwise, ESLint seems to fail at parsing this.
ehmicky
force-pushed
the
chore/eslint-config-node
branch
from
678b3e4 to
f040593
Compare
erezrokah
approved these changes
Dec 9, 2020
This was referenced Dec 14, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
eslint-config-node.Many rule are currently disabled, in an effort to add this incrementally.