Adding asdot notation to ASN views #8329
Conversation
Adds custom property to asn model to compute asdot notation if required. Updates asn view to show asdot notation if one exists in the format xxxxx (yyy.yyy) Adds a custom column renderer to asn table to display asdot notation if one exists
|
@jeremystretch Soliciting some feedback on this. Should the page title also be updated to include the asdot notation or not? E.g. |
|
Sure? No strong opinion here. |
jeremystretch
left a comment
jeremystretch
left a comment
There was a problem hiding this comment.
Thanks for this! Just had a couple suggestions.
netbox/ipam/models/ip.py
Outdated
| def __str__(self): | ||
| return f'AS{self.asn}' | ||
| if self.asn > 65535: | ||
| return 'AS{} ({}.{})'.format(self.asn, self.asn // 65536, self.asn % 65536) |
There was a problem hiding this comment.
This should probably return self.asdot_notation.
There was a problem hiding this comment.
I think we should also stick with fstrings if we can IMO
There was a problem hiding this comment.
Updated to use fstring and to return asn_with_asdot per below suggestion. Resulting code is much cleaner.
netbox/ipam/models/ip.py
Outdated
| return reverse('ipam:asn', args=[self.pk]) | ||
|
|
||
| @property | ||
| def asdot_notation(self): |
There was a problem hiding this comment.
Maybe rename this to asn_with_asdot or something like that, and return either the ASN with ASDOT notiation or just the ASN. Then you can reference it directly from within the ASNTable and object template.
There was a problem hiding this comment.
Great suggestion. That works much cleaner. Updated ASNTable & object template.
* Updating asdot computation to use an fstring * Cleaning code. Custom property now returns either the ASN with ASDOT notation or just the ASN. asn_with_asdot can now be referenced in ASNTable & objet template.
|
Excellent, thanks @jasonyates! |
3 participants
Fixes: #8293
Adds custom property to asn model to compute asdot notation if required.
Updates asn view to show asdot notation if one exists in the format xxxxx (yyy.yyy)
Adds a custom column renderer to asn table to display asdot notation if one exists