support for asdot notation for 4 Byte ASN

[empusas]

NetBox version

v3.1.5

Feature type

Change to existing functionality

Proposed functionality

In the netbox url/ipam/asns/ and netbox ur>/ipam/asns/#/ view the AS Number should be displayed in asplain and asdot notation.
The db model does not have to be changed as we can still only store the asplain value in the db.

The actual conversion can be done in the web browser with some simple javascript like this:

 function conv_asplain2asdot() {
        asplain = document.AScalc.asplain.value;
        var asdot1 = (Math.floor(asplain/65536));
        var asdot2 = asplain%65536;
        document.AScalc.asdot1.value = asdot1;
        document.AScalc.asdot2.value = asdot2;
};

function conv_asdot2asplain() {
        var asdot1 = document.AScalc.asdot1.value;
        var asdot2 = document.AScalc.asdot2.value;
        asplain = ((parseInt(asdot1) * 65536) + parseInt(asdot2));
        document.AScalc.asplain.value = asplain;
};

Use case

4 Byte AS number get more popular these day and the asdot notation seems to be much easier to work with.

Database changes

not required, conversion can be done in javascript at runtime as mentioned above.

External dependencies

none

[DanSheps]

I understand this was done in JS, but should this also be targetted for the API or do you think it is not needed as API consumers should be capable of handling it?

[empusas]

I think is is just more convenient for humans. As the conversion can be done really simple API users should be able to convert themself.
But you are right, it could be done on the server side as well, while keeping only the asplain value in the DB.

[jeremystretch]

In the UI, we can just display both formats in the UI for AS number larger than 65535. We should also come up with a custom form field to handle input in either format. IMO though the REST API should only return the plain integer format.

[empusas]

How do you want to add it in? Extend the ASN base class with the conversion functions or just add it into the table creation?

[jasonyates]

What would be the best way to display this?

With an additional row:

Appending the asdot version alongside the asplain. E.g.:

Same would apply to the table view. An extra column or appending it after the existing value.

[jeremystretch]

I would just put it in parentheses immediately following the first value.