Skip to content

#19550 Enhancement: Refactor rack elevations template for lazy loading /dcim/rack-elevations/ #19549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

#19550 Enhancement: Refactor rack elevations template for lazy loading /dcim/rack-elevations/ #19549

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
34a0d89
Refactor rack elevation template to use htmx for dynamic loading and …
tbot-ziply May 20, 2025
17cbd19
rework to prevent dup loading
tbotnz May 21, 2025
bb20578
Update netbox/templates/dcim/inc/rack_elevation.html
tbotnz Jun 9, 2025
33f7f15
Update netbox/templates/dcim/inc/rack_elevation.html
tbotnz Jun 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion netbox/templates/dcim/inc/rack_elevation.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,17 @@
{% load i18n %}
<div style="margin-left: -30px">
<object data="{% url 'dcim-api:rack-elevation' pk=object.pk %}?face={{face}}&render=svg{% if extra_params %}&{{ extra_params }}{% endif %}" class="rack_elevation" aria-label="{% trans "Rack elevation" %}"></object>
<div
hx-get="{% url 'dcim-api:rack-elevation' pk=object.pk %}?face={{ face }}&render=svg{% if extra_params %}&{{ extra_params }}{% endif %}"
hx-trigger="intersect"
hx-swap="outerHTML"
aria-label="{% trans "Rack elevation" %}"
>
<div class="d-flex justify-content-center align-items-center" style="min-height: 200px; margin-left: 30px;">
Copy link
Member

@jeremystretch jeremystretch Jun 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inline styles are generally not permitted. If these attributes are necessary, they should be declared under a class in the source Sass.

Copy link
Contributor Author

@tbotnz tbotnz Jun 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line 2 of the template begs to differ, however point taken

<div class="spinner-border" role="status">
<span class="visually-hidden">{% trans "Loading..." %}</span>
</div>
</div>
</div>
</div>
<div class="text-center mt-3">
<a class="btn btn-outline-primary" href="{% url 'dcim-api:rack-elevation' pk=object.pk %}?face={{face}}&render=svg{% if extra_params %}&{{ extra_params }}{% endif %}" hx-boost="false">
Expand Down