#19550 Enhancement: Refactor rack elevations template for lazy loading /dcim/rack-elevations/ #19549
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…improved user experience
tbotnz
changed the title
jeremystretch
requested changes
Jun 3, 2025
| hx-swap="outerHTML" | ||
| aria-label="{% trans 'Rack elevation' %}" | ||
| > | ||
| <div class="d-flex justify-content-center align-items-center" style="min-height: 200px; margin-left: 30px;"> |
Member
There was a problem hiding this comment.
Inline styles are generally not permitted. If these attributes are necessary, they should be declared under a class in the source Sass.
Contributor
Author
There was a problem hiding this comment.
line 2 of the template begs to differ, however point taken
Co-authored-by: Jeremy Stretch <[email protected]>
Co-authored-by: Jeremy Stretch <[email protected]>
jnovinger
force-pushed
the
add-rack-lazy-loading
branch
from
1a8a37f to
33f7f15
Compare
Member
|
Closing in favor of #19823, which has inline styles moved to the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #19550
The existing rack elevations template does not scale well, for e.g if the user has the pagination set 1000, the rack elevation template will try and make a rack http call for every rack when the page loads (#19550)
this PR does the following