Skip to content

Fixes: #18433 - Fix missing is_primary property on MACAddress model #18444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 27, 2025
Merged

Fixes: #18433 - Fix missing is_primary property on MACAddress model #18444

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
51a7950
Fixes: #18433 - Fix missing is_primary property on MACAddress model
DanSheps Jan 21, 2025
3219609
Change to `@cached_property`
DanSheps Jan 24, 2025
ee5d7cf
Merge branch 'main' into 18433-fix-macaddress-primary-for-interface
DanSheps Jan 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions netbox/dcim/models/devices.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1531,6 +1531,13 @@ def __init__(self, *args, **kwargs):
self._original_assigned_object_id = self.__dict__.get('assigned_object_id')
self._original_assigned_object_type_id = self.__dict__.get('assigned_object_type_id')

@cached_property
def is_primary(self):
if self.assigned_object and hasattr(self.assigned_object, 'primary_mac_address'):
if self.assigned_object.primary_mac_address and self.assigned_object.primary_mac_address.pk == self.pk:
return True
return False

def clean(self, *args, **kwargs):
super().clean()
if self._original_assigned_object_id and self._original_assigned_object_type_id:
Expand Down
Loading