You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I had is_primary on the model as a concrete field initially, then changed it to primary_for_interface field on the related model during development/review. I guess the template still had the vestigial mention. I'm not sure why we didn't put it back in as a property, but I seem to remember wanting to but there was some argument against it?
Approved for the moment, but there might be some discussion to be had.
I had is_primary on the model as a concrete field initially, then changed it to primary_for_interface field on the related model during development/review. I guess the template still had the vestigial mention. I'm not sure why we didn't put it back in as a property, but I seem to remember wanting to but there was some argument against it?
I think is_primary as a "Boolean" makes sense. If it was is_primary as the reverse relation it would be kind of weird IMO.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #18433 - Add missing is_primary property on MACAddress model
is_primaryproperty method onMACAddressmodel