15427 Use endpoint_url in S3Backend #15742
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremystretch
approved these changes
Apr 17, 2024
Member
jeremystretch
left a comment
jeremystretch
left a comment
There was a problem hiding this comment.
Thanks @javierdelapuente!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #15427
This PR includes the
endpoint_urlparameter to the call toboto3.resourcefor theS3Backend. This allows to use external S3 servers.I have tested the code against AWS S3 and and also against a local server using Minio. These url formats work correctly:
https://s3.amazonaws.com/<bucket-name>https://s3.<region-name>.amazonaws.com/<bucket-name>https://<your-s3-server>/<bucket-name>Virtual-host-style and s3 protocol (s3://) do not work, but they were not working before this PR.