-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Description
NetBox version
v3.7.4
Feature type
Change to existing functionality
Proposed functionality
Data sources of type Amazon S3 do not work with compatible S3 servers. The proposal is to allow S3 compatible servers to be used as data sources.
Currently, there is a datasource of type "Amazon S3", that uses Amazon S3 in AWS. When creating the data source, the URL protocol and domain/netloc are not taken into account (except to obtain the region), so by default only AWS can be used.
The proposal is to add the argument endpoint_url to construct the boto3.resource, so S3 compatible servers can be used. The proposed change will be located in here:
netbox/netbox/core/data_backends.py
Line 147 in 4adb44f
| s3 = boto3.resource( |
As a workaround, environment variables can be used (like AWS_ENDPOINT_URL), but that limits all S3 data sources to reside in that url.
Use case
This feature will allow NetBox users to use other cloud providers or to host their own S3 compatible servers instead of using AWS to store their scripts and reports for Amazon S3 datasources.
Database changes
None
External dependencies
None