Skip to content

Fixes #15090: Run deletion protection rules prior to enqueueing events #15196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 20, 2024
Merged

Fixes #15090: Run deletion protection rules prior to enqueueing events #15196

merged 1 commit into from
Feb 20, 2024

Conversation

@jeremystretch
Copy link
Member

@jeremystretch jeremystretch commented Feb 20, 2024

Fixes: #15090

  • Move run_validators() to extras.validators
  • Absorb run_delete_validators() logic into handle_deleted_object(), ensuring that it is executed before events are enqueued

@jeremystretch jeremystretch merged commit dbcd713 into develop Feb 20, 2024
@jeremystretch jeremystretch deleted the 15090-protected-deletion-webhooks branch February 20, 2024 18:22
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@arthanson arthanson arthanson approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Webhooks sent despite protection rule block

3 participants

@jeremystretch @arthanson