Webhooks sent despite protection rule block

[ryankearney]

Deployment Type

Self-hosted

NetBox Version

v3.7.2

Python Version

3.10

Steps to Reproduce

1. Create a webhook that triggers on an IP Address delete
2. Create a custom protection rule that will block deletion if IP addresses. For example: { "ipam.ipaddress": [ { "status": { "eq": "deprecated" } } ] }
3. Go delete an IP address object that does not satisfy the protection rule
4. Observe the error message Deletion is prevented by a protection rule: {'status': ['Ensure this value is equal to deprecated.']} (this is expected)
5. Observe the webhook firing for an ipaddress deletion (this is unexpected)

Expected Behavior

Webhook should not fire on deletion if a protection rule prevented the deletion from happening.

Observed Behavior

Webhook is sent sent with event deleted and a snapshot.postchange value of null despite the system blocking this deletion. This could have implications on webhook receivers processing the deletion when in fact the object remains in NetBox.

[renatoalmeidaoliveira]

I can think in two ways to solve this Issue
1 Change handle_deleted_object event to post_delete.
2 Join handle_deleted_object and run_delete_validators in a single pre_delete method.
If I would fix that issue I would go for option 2.
I can make a fix for that issue, just let me know which path is the best.

[jeremystretch]

1. Change handle_deleted_object event to post_delete.

I don't think this is feasible, because the receiver function is also responsible for recording a change record. This must happen before the object is deleted e.g. to retain its primary key.

2. Join handle_deleted_object and run_delete_validators in a single pre_delete method.

IMO this would be the preferred solution.