Skip to content

Fixes #12219: Ensure dashboard widget heading text has sufficient contrast #13753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 13, 2023
Merged

Fixes #12219: Ensure dashboard widget heading text has sufficient contrast #13753

merged 2 commits into from
Sep 13, 2023

Conversation

@jeremystretch
Copy link
Member

@jeremystretch jeremystretch commented Sep 13, 2023

Fixes: #12219

  • Introduces the fg_color property on DashboardWidget to return white or black as appropriate given the assigned background color
  • Modifies the widget template to use that color for all heading elements

dashboard_light
dashboard_dark

@jeremystretch jeremystretch mentioned this pull request Sep 13, 2023
Closed
@jeremystretch jeremystretch merged commit 6939bf8 into develop Sep 13, 2023
@jeremystretch jeremystretch deleted the 12219-widget-colors branch September 13, 2023 14:56
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

New dashboard widgets have insufficient header contrast in dark mode

2 participants

@jeremystretch