Skip to content

Conversation

@arthanson
Copy link
Collaborator

Fixes: #12219

  1. updates foreground_color template tag to work with color values "red" instead of hex values.
  2. change widget template to use this for text and icons
  3. adds some utility functions to lighten (and darken) a color, used to make gear and close icons lighter then text

@arthanson arthanson requested a review from jeremystretch May 2, 2023 21:51
@arthanson
Copy link
Collaborator Author

@jeremystretch went through all the colors in dark mode and it works there as well. However "Default" on dark mode doesn't work (black on dark-grey) however IMHO we should look at a separate issue/bug to remove or replace Default as it currently uses outline-dark which is not a color and is just he widget background color which is not very useful in either dark or light mode. I don't think it is possible to fix this for Default as it is the background widget color that changes between dark and light mode which isn't detectable from python. I think removing default should be a separate issue as it will require some migrations and we may want to refactor widget color more.

This fixes the text color for widgets and I think is useful, it just doesn't fix it for dark mode default (which should probably be removed).

@github-actions
Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity. It will be closed automatically if no further action is taken.

@github-actions github-actions bot added the pending closure Requires immediate attention to avoid being closed for inactivity label Aug 18, 2023
@jeremystretch jeremystretch removed the pending closure Requires immediate attention to avoid being closed for inactivity label Sep 13, 2023
@jeremystretch
Copy link
Member

I'm to close this out in favor of the simpler fix in PR #13753. We may reconsider something more elegant as part of the upcoming UI refresh.

@jeremystretch jeremystretch deleted the 12219-widget-contrast branch September 13, 2023 13:50
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

New dashboard widgets have insufficient header contrast in dark mode

3 participants