Add new endpoints for vpn app #1162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freddebacker
force-pushed
the
issues_1146_1149_patch
branch
2 times, most recently
from
30df3b6 to
3c4b34f
Compare
freddebacker
force-pushed
the
issues_1146_1149_patch
branch
from
3c4b34f to
404795c
Compare
freddebacker
force-pushed
the
issues_1146_1149_patch
branch
from
0c17391 to
fb46974
Compare
sc68cal
reviewed
Feb 6, 2024
Contributor
sc68cal
left a comment
sc68cal
left a comment
There was a problem hiding this comment.
I think I'd rather see comparisons like (major, minor, patch) <= instead of declaring a new variable.
sc68cal
approved these changes
Feb 8, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
#1149
New Behavior
vpn.tunnelandvpn.tunnel_terminationobjects.l2vpnandl2vpn_terminationto the correct appipamorvpnFix
l2vpnandl2vpn_terminationsupport for netbox 3.7Contrast to Current Behavior
Works against netbox 3.7 as well, which was broken because endpoint moved
...
Discussion: Benefits and Drawbacks
...
Changes to the Documentation
...
Proposed Release Note Entry
...
Double Check
develbranch.