Update nb_lookup.py with the new vpn app in netbox 3.7 #1146 #1149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sc68cal
requested changes
Jan 12, 2024
Contributor
sc68cal
left a comment
sc68cal
left a comment
There was a problem hiding this comment.
We have to support versions < 3.7 so you need to take a look at
That is how we handle changes in the API between versions.
Author
|
Thanks for the hint. Will look those days 👍 |
Contributor
|
No problem. Just note that the versions that code is looking at is the pynetbox version, so you need to look for a version greater than or equal to 7.3.0 |
3 tasks
Contributor
|
Added in #1162 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
#1146
New Behavior
In netbox 3.7 vpns got an own app. L2VPNs moved and tunnels were added.
Contrast to Current Behavior
New app
Discussion: Benefits and Drawbacks
Needed to work with newes netbox version
Changes to the Documentation
dont think so
Proposed Release Note Entry
Added support for vpn add to nb_lookup
...
Double Check
develbranch.