Fixed Session#reset() #418
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's needed because RESET makes server terminate all running messages and then moves state machine to idle READY state. That's why it does not expect clients to ACK_FAILURE for terminated messages. Absence of this muting caused server to sometimes fail saying: "ACK_FAILURE cannot be handled by a session in the READY state". Also removed some unused blocking API classes and better naming for connection methods.
It got broken after moving all blocking APIs to use async ones underneath. This commit makes session send RESET message on the active connection and move existing transaction to TERMINATED state. Transactions in this state will disallow running new queries and committing. All existing tests for `Session#reset()` are now un-ignored and couple new unit tests are added.
Main those that do flushing. Now it's handled by netty channels.
lutovich
force-pushed
the
1.5-session-reset
branch
from
f7fc39e to
b18d7ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It got broken after moving all blocking APIs to use async ones underneath.
This commit makes session send RESET message on the active connection and move existing transaction to TERMINATED state. Transactions in this state will disallow running new queries and committing. All existing tests for
Session#reset()are now un-ignored and couple new unit tests are added.Based on #417