Treat request errors as fatal #419
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lutovich
force-pushed
the
1.5-fatal-errors-from-db
branch
3 times, most recently
from
9f1e537 to
2168c2f
Compare
Fatal errors result in network channel being closed. Previously only some errors that originate in the driver were treated as fatal. However some errors received from the database mean communication is broken. This commit makes protocol errors that start with `Neo.ClientError.Request` be treated as fatal. No ACK_FAILURE will be send for such errors and netty channel will be closed.
lutovich
force-pushed
the
1.5-fatal-errors-from-db
branch
from
2168c2f to
2124cac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fatal errors result in network channel being closed. Previously only some errors that originate in the driver were treated as fatal. However some errors received from the database mean communication is broken.
This PR makes protocol errors that start with
Neo.ClientError.Requestbe treated as fatal. No ACK_FAILURE will be send for such errors and netty channel will be closed.