Skip to content

Conversation

fanofxiaofeng
Copy link
Contributor

疑似写错了一个字

疑似写错了一个字
@harawata harawata merged commit 290afb5 into mybatis:master Sep 27, 2018
@harawata
Copy link
Member

Thanks!

FYI, the original sentence is a little bit tricky to translators (I think).
This might be easier:

Namespace is now required. And they are not only used to isolate statements with longer, fully qualified names.

By Google Translate...

现在需要命名空间。 它们不仅用于隔离具有更长,完全限定名称的语句。

@kazuki43zoo kazuki43zoo added the documentation Indicates a changing on documentation(reference or javadoc) label Sep 27, 2018
@CodeingBoy CodeingBoy mentioned this pull request Oct 1, 2018
@CodeingBoy
Copy link
Contributor

This is not correct.

Namespaces are now required and have a purpose beyond simply isolating statements with longer, fully-qualified names.

The english doc is stating "purpose", not "convenient".

I have reverted this change in #1289. Also, I will try rewriting this sentence for better understanding.

Anyway, thanks for your effort.

@CodeingBoy
Copy link
Contributor

CodeingBoy commented Oct 1, 2018

In #1289, I rewrote this sentence to:

在之前版本的 MyBatis 中,命名空间(Namespaces)的作用并不大,是可选的。但现在,随着命名空间越发重要,你必须指定命名空间。
命名空间的作用有两个,一个是利用更长的完全限定名来将不同的语句隔离开来,同时也实现了你上面见到的接口绑定。

Translating them back to English:

In previous versions of MyBatis, Namespaces are not very useful, they are optional. As namespaces plays an important role in current MyBatis, you have to specify namespaces.
There are two reasons for using namespaces, first, isolating statements with longer, fully-qualified names. Second, enable the interface bindings as you see here.

The original english sentences did have a little bit tricky, I have misunderstood that, sorry about that.

@fanofxiaofeng Hope you can read this version of docs. Let us know if you have better idea.

EDIT: typo

@fanofxiaofeng
Copy link
Contributor Author

got it~

pulllock pushed a commit to pulllock/mybatis-3 that referenced this pull request Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Indicates a changing on documentation(reference or javadoc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants