Skip to content

Conversation

CodeingBoy
Copy link
Contributor

After #1140 , I realized there's still a lot of docs improvement can be done. So I planned going through the whole MyBatis documentation and modify poorly-written sentences. Now I have accomplished a set of changes, which contains changes of:

  • Index
  • Getting started
  • Configuration
  • Mapper XML

The rest of work may take several months. Since I don't have much spare time, I'd like to commit them now. Feel free to merge. :)

@harawata
Copy link
Member

Thanks a lot for your hard work, @CodeingBoy !
Unfortunately, there are a few minor conflicts.
Could you resolve them and update this PR, by any chance?

@CodeingBoy
Copy link
Contributor Author

Conflicts resolved. I'm going to build these docs again, making sure they are not corrupted.
Note that I have reverted changes from #1359, which is not correct.

@CodeingBoy CodeingBoy mentioned this pull request Oct 1, 2018
@CodeingBoy
Copy link
Contributor Author

Please don't merge this PR as I'm working on several changes.

@harawata
Copy link
Member

harawata commented Oct 1, 2018

Okay. Please let us know when it's ready.
Thank you for your work!

@CodeingBoy
Copy link
Contributor Author

Hello @harawata, changes were committed. You can merge them now. :)

@harawata harawata merged commit 48e42b9 into mybatis:master Oct 1, 2018
@harawata
Copy link
Member

harawata commented Oct 1, 2018

Thank you both for your work, @CodeingBoy and @fanofxiaofeng !

And I'm sorry about the conflict. It should not have happened.

@harawata harawata added the documentation Indicates a changing on documentation(reference or javadoc) label Oct 1, 2018
@CodeingBoy
Copy link
Contributor Author

That's OK, don't worry. :) I'm very appreciate your effort for maintaining this project.

pulllock pushed a commit to pulllock/mybatis-3 that referenced this pull request Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Indicates a changing on documentation(reference or javadoc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants