-
-
Notifications
You must be signed in to change notification settings - Fork 499
Death Event Parameters Synchronization Fix #4418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
FileEX
merged 6 commits into
multitheftauto:master
from
MohabCodeX:fix/onplayerwasted-wrong-params
Sep 5, 2025
Merged
Death Event Parameters Synchronization Fix #4418
FileEX
merged 6 commits into
multitheftauto:master
from
MohabCodeX:fix/onplayerwasted-wrong-params
Sep 5, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This is likely to be backward-incompatible because of the explosion type ID change. |
Contributor
|
Perfect fix for 1.7 😄 |
FileEX
requested changes
Sep 4, 2025
FileEX
approved these changes
Sep 5, 2025
This was referenced Sep 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backwards-incompatible
Should be merged after the release of 1.7.1
bugfix
Solution to a bug of any kind
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issues #2312 and #2273 where
onPlayerWastedandonClientPlayerWastedevents received inconsistent parameters when players died viasetElementHealthor vehicle explosions.Root Cause: Race condition between health RPC packets and client-side death events caused
DoWastedCheck()to fire with stale damage data, resulting in inconsistent parameters between server and client death events.Solution: Added client-side flag
m_bServerProcessedDeathto prevent stale data usage and implemented dynamic weapon data retrieval.Results
Vehicle Explosion
This also incidentally fixed an additional bug:
The inconsistent value of
63that appeared when dying from a vehicle explosion. It was hardcoded and unrelated to the correct ID, which is51. Please note that the information on the wiki will need to be updated accordingly. I will provide the full list of damage types later.