-
-
Notifications
You must be signed in to change notification settings - Fork 501
Add cef upgrade script #1332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cef upgrade script #1332
Conversation
5eb3075 to
ff02a52
Compare
|
"but it works on my machine!" my pc too |
86539c3 to
c7e5cdf
Compare
currently: - prints new hash and version - unpacks new version
Revert to old method of computing hash (CertUtil) because escaping batch scripts is broken
c7e5cdf to
9b5dd05
Compare
|
ok, this is ready for review 👍 This change
caused issues with CI. It basically boiled down to some inconsistency in executing things in powershell. So i've reverted to the old method of generating SHA256 hashes |
|
I'm currently not able to test it, but it looks good to me. If it works, feel free to merge it! |
|
Thanks! Next task is automated pull requests :-) |
Passing
upgradeshould say this (bonus: windows not necessary)if you're on windows it will then proceed to install that new cef version
and
git diffproduces the following patchIf CEF is already up to date (i.e CEF_VERSION matches what the server says)
Also now we do a consistency check after download too