Skip to content

Conversation

@qaisjp
Copy link
Contributor

@qaisjp qaisjp commented Mar 16, 2020

New old builds should be fine because Spotify hosts CEF archives for years:

  1. http://opensource.spotify.com/cefbuilds/index.html
  2. wait a couple seconds for the entire page to load, javascript will prettify the page (yes actually wait)
  3. scroll to "Windows 32bit" and click 'Show more builds'
  4. oldest build available is 05/26/2016 - CEF 3.2704.1414.g185cd6c / Chromium 51.0.2704.47

Might be worth adding the sha1 to the config section, so that someone can't change the binaries underneath us (and spotify) and replace them with malicious files. Let me know if I should do this.

@qaisjp qaisjp force-pushed the feature/use-spotify-cef branch from dbb881b to 2a136c3 Compare March 16, 2020 19:38
@qaisjp qaisjp force-pushed the feature/use-spotify-cef branch from 2a136c3 to ffdc9b9 Compare March 16, 2020 19:49
@qaisjp qaisjp requested a review from jushar March 17, 2020 07:59
@qaisjp qaisjp added enhancement New feature or request and removed refactor labels Mar 17, 2020
@AlexTMjugador
Copy link
Member

AlexTMjugador commented Mar 18, 2020

If malicious builds are a concern, and the hash expected life time is high, then I think that we should be using SHA256 instead of SHA1 for checking for file integrity. See: https://en.wikipedia.org/wiki/File_verification#File_formats

@qaisjp qaisjp modified the milestones: Backlog, 1.6 Mar 23, 2020
@jushar
Copy link
Contributor

jushar commented Mar 27, 2020

If we use SHA256 instead of SHA1, could you also add a build action that downloads the archive, calculates the hash and prints it to the console?

E.g. something like

premake5 calc-cef-hash "80.0.8+gf96cd1d+chromium-80.0.3987.132"

Or alternatively, we could also automate the update process entirely by writing the url + hash to an additional file (e.g. a json file or something else premake can parse) and use that for downloading CEF.

Other than that, the patch looks fine to me and is ready for merging.

@qaisjp qaisjp merged commit 0b14837 into multitheftauto:master Mar 27, 2020
@qaisjp qaisjp deleted the feature/use-spotify-cef branch March 27, 2020 09:15
@qaisjp
Copy link
Contributor Author

qaisjp commented Mar 27, 2020

sorry i didn't read, i'll do that now

@qaisjp
Copy link
Contributor Author

qaisjp commented Mar 28, 2020

requested feature done in #1332

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants