Skip to content

Conversation

@alcaeus
Copy link
Member

@alcaeus alcaeus commented Jul 7, 2021

DRIVERS-1836

Note that the CRUD v1 tests still contain unavailable functionality (namely collate which has also been disabled), but I don't believe we've added support for the serverless runOnRequirement in that test format, so I'd avoid touching those tests. Drivers that run the CRUD v1 tests on serverless should skip or exclude the offending tests separately.

@alcaeus alcaeus self-assigned this Jul 7, 2021
@alcaeus alcaeus requested review from a team as code owners July 7, 2021 08:09
@alcaeus alcaeus requested review from benjirewis and jmikola and removed request for a team July 7, 2021 08:09
@jmikola
Copy link
Member

jmikola commented Jul 7, 2021

Drivers that run the CRUD v1 tests on serverless should skip or exclude the offending tests separately.

No objections there, but it should be clearly specified in the DRIVERS ticket when languages sync up with these tests. 3586db8 added serverless to the legacy transactions format, but that already included something similar to runOn in the unified format.

CRUD v1 just has top-level fields (https://github.com/mongodb/specifications/tree/master/source/crud/tests#legacy-v1-test-format-for-single-operations) with no topology checks IIRC.

"load-balanced"
]
],
"serverless": "forbid"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These tests aren't failing for me. Do they need to be disabled?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, these tests set a fail point, so they will never trigger the underlying error. I've removed the requirement for this test.

@alcaeus alcaeus removed the request for review from benjirewis July 9, 2021 06:40
@alcaeus alcaeus merged commit c3e22b0 into mongodb:master Jul 9, 2021
@alcaeus alcaeus deleted the drivers-1836 branch July 9, 2021 06:45
p-mongo pushed a commit to p-mongo/specifications that referenced this pull request Jul 13, 2021
* upstream/master:
  DRIVERS-1836 Skip tests with $out stage on serverless (mongodb#1036)
  DRIVERS-1816 Test redaction of replies to security sensitive commands (mongodb#1026)
  DRIVERS-1828: Remove insertedCount and improve use of $$unsetOrMatches (mongodb#1034)
  DRIVERS-1819 Disable writes and other unsupported operations in snapshot reads (mongodb#1033)
kevinAlbs pushed a commit to kevinAlbs/specifications that referenced this pull request Nov 9, 2021
* Skip tests with $out stage on serverless

* Run test expecting failure on $out
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants