Skip to content

Conversation

@jmikola
Copy link
Member

@jmikola jmikola commented Jul 1, 2021

https://jira.mongodb.org/browse/DRIVERS-1828

I ran the modified tests through PHPLIB, but would appreciate it if someone else tests in their driver as well.

@jmikola jmikola requested review from abr-egn, alcaeus and nbbeeken July 1, 2021 15:21
@jmikola jmikola requested review from a team as code owners July 1, 2021 15:21
@jmikola jmikola requested review from benjirewis and removed request for a team July 1, 2021 15:21
Copy link
Contributor

@abr-egn abr-egn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran these changes through the Rust driver, all good.

@jmikola
Copy link
Member Author

jmikola commented Jul 2, 2021

@abr-egn: Thanks. I'll merge as soon as @alcaeus approves (as CRUD spec owner).

@jmikola jmikola merged commit 44f8310 into mongodb:master Jul 2, 2021
@jmikola jmikola deleted the drivers-1828 branch July 2, 2021 13:22
p-mongo pushed a commit to p-mongo/specifications that referenced this pull request Jul 13, 2021
* upstream/master:
  DRIVERS-1836 Skip tests with $out stage on serverless (mongodb#1036)
  DRIVERS-1816 Test redaction of replies to security sensitive commands (mongodb#1026)
  DRIVERS-1828: Remove insertedCount and improve use of $$unsetOrMatches (mongodb#1034)
  DRIVERS-1819 Disable writes and other unsupported operations in snapshot reads (mongodb#1033)
kevinAlbs pushed a commit to kevinAlbs/specifications that referenced this pull request Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants