[CLOUDP-332196] Remove dir public/tools after moving kubectl plugin to cmd/kubectl-mongodb
#281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ster This commit moves the source code of mongodb kubectl plugin from `public/tools/multicluster` to `cmd` directory. This is to align with how go code that ships a CLI is structured. The command/subcommand building logic is moved to the `cmd` directory and and rest of the logic The command/subcommand building logic is moved to the `cmd` directory and and rest of the logic is moved to the new package `pkg/kubectl-mongodb`. This commit also moves the `.goreleaser.yaml` to the root of the project because kubectl plugin is now at the root of the project.
1. Since most of our evergreen config files are in root of the repo and now that kubectl plugin is also moved to `cmd/` it makes sense to move the evergreen config file to the root of repo with correct name. 2. Change the goreleaser config file to version 1. We upgraded it temporarily to version 2 but CI complains that only version 1 is supported.
…m `multi_cluster/tools`
…to correct kubectl-mongodb root
Since we moved the code of `kubectl-mongodb` plugin to `cmd/` we needed to move the licenses files to the new location. This commit does that.
Since we moved the code for kubectl plugin to the dir `cmd/`, we also need to move the Dockerfile there. This commit does the same and moves the Dockerfile to the `cmd/kubectl-mongodb` dir.
…-mongodb` Since we moved everything related to the kubectl plugin to the dir `cmd/kubectl-mongodb`, this commit deletes the dir `public/tools` because it doesn't really have any valuable files now.
viveksinghggits
requested review from
fealebenpae,
m1kola,
MaciejKaras and
Julien-Ben
and removed request for
a team
viveksinghggits
added
the
skip-changelog
viveksinghggits
changed the title
public/tools after moving kubectl plugin to `cmd/kubectl…public/tools after moving kubectl plugin to cmd/kubectl-mongodb
Since we run the unit tests that are `pkg/kubectl-mongodb` from root of the repo. The result.suite file will not be generated in the `pkg/kuebctl-mongodb`, instead it will be there in the result.suite file that gets generated at the root of the repo. That's why we don't have to upload the file `result.suite` file from `pkg/kuebctl-mongodb`.
3 tasks
MaciejKaras
approved these changes
Jul 21, 2025
nammn
approved these changes
Jul 22, 2025
viveksinghggits
added a commit
that referenced
this pull request
Jul 22, 2025
# Summary As part of [the PR](#271) we moved the kubectl-mongodb code from `public/tools/multicluster` to `cmd/kubectl-mongodb`. This PR, tries to move the license file from `public/tools/multicluster` to `cmd/kubectl-mongodb`. The next [PR](#281) in this chain are going to actually remove the `public/tools` directory entirely. ## Proof of Work NA ## Checklist - [x] Have you linked a jira ticket and/or is the ticket in the title? - [x] Have you checked whether your jira ticket required DOCSP changes? - [x] Have you checked for release_note changes?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Since we moved everything related to the kubectl plugin to the dir
cmd/kubectl-mongodb, this commit deletes the dirpublic/toolsbecause it doesn't really have any valuable files now.Proof of Work
Run the test using the same command (
make golang-tests-race) that is used to run the unit tests on CI and make sure that the tests for kubectl-plugin packages, that are inpkg/kubectl-mongodb, are run.Another trivial change that this PR introduces is, now that the unit tests related to the kubectl-mongodb plugin are moved to
pkg/kubectl-mongodband we run them from the root of the repo. Theresult.suitefile will not be generated in thepkg/kubectl-mongodb, instead it will be part of theresult.suitefile that gets generated at the root of the repo. Which should be ok because we upload that tot he evergreen using the evergreen function.Checklist