Skip to content

Commit d841a8e

Browse files
[CLOUDP-332196] Remove dir public/tools after moving kubectl plugin to cmd/kubectl-mongodb (#281)
# Summary Since we moved everything related to the kubectl plugin to the dir `cmd/kubectl-mongodb`, this commit deletes the dir `public/tools` because it doesn't really have any valuable files now. ## Proof of Work Run the test using the same command (`make golang-tests-race`) that is used to run the unit tests on CI and make sure that the tests for kubectl-plugin packages, that are in `pkg/kubectl-mongodb`, are run. ``` ok github.com/mongodb/mongodb-kubernetes/pkg/kubectl-mongodb/common 9.709s coverage: 54.1% of statements === RUN TestNoOpAnonymizer_AnonymizeSecret --- PASS: TestNoOpAnonymizer_AnonymizeSecret (0.00s) === RUN TestSensitiveDataAnonymizer_AnonymizeSecret --- PASS: TestSensitiveDataAnonymizer_AnonymizeSecret (0.00s) === RUN TestCollectors --- PASS: TestCollectors (0.00s) === RUN TestWriteToFile --- PASS: TestWriteToFile (0.00s) === RUN TestCleanContext --- PASS: TestCleanContext (0.00s) PASS coverage: 45.8% of statements ok github.com/mongodb/mongodb-kubernetes/pkg/kubectl-mongodb/debug 2.144s coverage: 45.8% of statements === RUN TestGetRsNamefromMultiStsName --- PASS: TestGetRsNamefromMultiStsName (0.00s) === RUN TestGetRsNamefromMultiStsNamePanic --- PASS: TestGetRsNamefromMultiStsNamePanic (0.00s) === RUN TestLoadKubeConfigFile --- PASS: TestLoadKubeConfigFile (0.00s) PASS ``` Another trivial change that this PR introduces is, now that the unit tests related to the kubectl-mongodb plugin are moved to `pkg/kubectl-mongodb` and we run them from the root of the repo. The `result.suite` file will not be generated in the `pkg/kubectl-mongodb`, instead it will be part of the `result.suite` file that gets generated at the root of the repo. Which should be ok because we upload that tot he evergreen using the evergreen function. ## Checklist - [x] Have you linked a jira ticket and/or is the ticket in the title? - [x] Have you checked whether your jira ticket required DOCSP changes? - [x] Have you checked for release_note changes?
1 parent aa0f155 commit d841a8e

File tree

9 files changed

+3
-283
lines changed

9 files changed

+3
-283
lines changed

.dockerignore

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,6 @@ tools.go
5454
deploy/
5555
config/manifests/
5656
public/
57-
!/public/tools/multicluster/go.mod
5857

5958
# Documentation files
6059
docs/

.evergreen-functions.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -664,7 +664,7 @@ functions:
664664
make test-race
665665
- command: gotest.parse_files
666666
params:
667-
files: [ "src/github.com/mongodb/mongodb-kubernetes/*.suite", "src/github.com/mongodb/mongodb-kubernetes/public/tools/multicluster/*.suite", "src/github.com/mongodb/mongodb-kubernetes/docker/mongodb-kubernetes-init-ops-manager/mmsconfiguration/*.suite" ]
667+
files: [ "src/github.com/mongodb/mongodb-kubernetes/*.suite", "src/github.com/mongodb/mongodb-kubernetes/docker/mongodb-kubernetes-init-ops-manager/mmsconfiguration/*.suite" ]
668668

669669
test_python_unit:
670670
- command: shell.exec

.gitignore

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33

44
/pkg/client
55
/vendor/
6-
public/tools/multicluster/vendor
76
docker/mongodb-kubernetes-operator/content/mongodb-kubernetes-operator
87
docker/mongodb-kubernetes-database/content/mongodb-mms-automation-agent-version.properties
98
docker/mongodb-kubernetes-database/content/readinessprobe

public/.gitignore

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
11
.idea
22
*.iml
33
.DS_Store
4-
tools/multicluster/linux_amd64/*

public/tools/multicluster/.gitignore

Lines changed: 0 additions & 6 deletions
This file was deleted.

public/tools/multicluster/LICENSE-THIRD-PARTY

Lines changed: 0 additions & 42 deletions
This file was deleted.

public/tools/multicluster/go.mod

Lines changed: 0 additions & 61 deletions
This file was deleted.

0 commit comments

Comments
 (0)