Skip to content

CLOUDP-321526: Fix snooty error about two backticks #4024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

CLOUDP-321526: Fix snooty error about two backticks #4024

wants to merge 2 commits into from
+42 −42

Conversation

blva
Copy link
Collaborator

@blva blva commented Jul 3, 2025 •
edited
Loading

Proposed changes

Jira ticket: CLOUDP-321526

Checklist

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation in document requirements section listed in CONTRIBUTING.md (if appropriate)
  • I have addressed the @mongodb/docs-cloud-team comments (if appropriate)
  • I have updated test/README.md (if an e2e test has been added)
  • I have run make fmt and formatted my code

Further comments

blva added 2 commits July 3, 2025 12:58
@blva
address ' Monospace text uses two backticks () Did you mean: payload.…
7dc829e 
…json WARNING(command/atlas-api-databaseUsers-createDatabaseUser.txt:133ish): Monospace text uses two backticks'
@blva
update docs
29771ea
@blva blva marked this pull request as ready for review July 3, 2025 12:04
@blva blva requested review from a team as code owners July 3, 2025 12:04
@github-actions github-actions bot added atlascli need-doc-review Improvements or additions to documentation, will be reviewed by the docs team labels Jul 3, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 3, 2025

APIx Bot :bowtie:: a message has been sent to Docs Slack channel 🚀.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 3, 2025

Coverage Report 📈

Branch Commit Coverage
master 1a8e42d 25.7%
CLOUDP-321526 29771ea 25.7%
Difference 0%

@blva blva mentioned this pull request Jul 3, 2025
Closed
lmkerbey-mdb
lmkerbey-mdb reviewed Jul 3, 2025
View reviewed changes
Copy link
Contributor

@lmkerbey-mdb lmkerbey-mdb left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the error that this is intended to address? Double-backticks are the appropriate format for monospacing text, with single-backticks used for specific directive types. Please provide an error log so I can investigate.

@blva
Copy link
Collaborator Author

blva commented Jul 3, 2025

What is the error that this is intended to address? Double-backticks are the appropriate format for monospacing text, with single-backticks used for specific directive types. Please provide an error log so I can investigate.

You're right! I think we duplicated this ticket and I ended up trying to reverse the fix instead. I'll close this PR :)

@blva blva closed this Jul 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmkerbey-mdb lmkerbey-mdb lmkerbey-mdb left review comments

@jeroenvervaeke jeroenvervaeke jeroenvervaeke approved these changes

Assignees
No one assigned
Labels
atlascli need-doc-review Improvements or additions to documentation, will be reviewed by the docs team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@blva @jeroenvervaeke @lmkerbey-mdb