CDRIVER-4385 Increase ClangFormat ColumnLimit from 80 to 120 #1545
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vector-of-bool
approved these changes
Feb 26, 2024
Contributor
vector-of-bool
left a comment
vector-of-bool
left a comment
There was a problem hiding this comment.
Perfect. No notes.
kevinAlbs
approved these changes
Feb 27, 2024
Contributor
Author
|
Note: observed no formatting changes relative to the latest commit 83211f1, so will rebase-merge as-is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially resolves CDRIVER-4385 (column limit).
This PR applies a single change to the ClangFormat configuration: raising ColumnLimit from 80 to 120. The value of 120 is inherited from #1139. A separate, dedicated "format" commit applies the updated configuration to the source files. This "format" commit will continue to be rebase-updated until this PR is approved and merged.
Once approved, this PR will be merged using the "Rebase and merge" option to preserve the two separate commits. A followup PR will add the post-merge hash of only the "format" commit to the .git-blame-ignore-revs file.
Further changes to the ClangFormat config are expected to follow the same formula: