Skip to content

Conversation

ianf-mongodb
Copy link
Contributor

No description provided.

@jeff-allen-mongo jeff-allen-mongo merged commit a19e440 into mongodb:v4.2 Aug 16, 2021
mongo-cr-bot pushed a commit that referenced this pull request Jan 3, 2024
mongodb-server-docs-sync-bot bot pushed a commit that referenced this pull request Jul 23, 2025
… Hash#__mongoid_unsatisfiable_criteria? (#5700)

* - Remove ``Object#blank_criteria?`` method entirely (was previously deprecated and not used in code.)
- Remove ``Hash#_mongoid_unsatisfiable_criteria?`` method is removed (was previously marked @api private) and move it to a private method of Referenced::HasMany::Enumerable.

* Update enumerable.rb

* removing the specs for unsatisifiable_criteria

this tests an implementation detail and not a behavior, which is
fragile. I'm not even sure this is an implementation detail we want,
and testing it specifically pours metaphorical concrete around it,
making it that much harder to remove later.

---------

Co-authored-by: Jamis Buck <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants