Skip to content

Commit 389fd79

Browse files
johnnyshieldsjamis
andauthored
MONGOID-5671 [Monkey Patch Removal] Remove Object#blank_criteria? and Hash#__mongoid_unsatisfiable_criteria? (#5700)
* - Remove ``Object#blank_criteria?`` method entirely (was previously deprecated and not used in code.) - Remove ``Hash#_mongoid_unsatisfiable_criteria?`` method is removed (was previously marked @api private) and move it to a private method of Referenced::HasMany::Enumerable. * Update enumerable.rb * removing the specs for unsatisifiable_criteria this tests an implementation detail and not a behavior, which is fragile. I'm not even sure this is an implementation detail we want, and testing it specifically pours metaphorical concrete around it, making it that much harder to remove later. --------- Co-authored-by: Jamis Buck <[email protected]>
1 parent 0a7b4b4 commit 389fd79

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

source/release-notes/mongoid-9.0.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,7 @@ Deprecated functionality removed
7474
The method ``Mongoid::QueryCache#clear_cache`` should be replaced with ``Mongo::QueryCache#clear``.
7575
All other methods and submodules are identically named. Refer to the `driver query cache documentation
7676
<https://mongodb.com/docs/ruby-driver/current/reference/query-cache/>`_ for more details.
77+
- ``Object#blank_criteria?`` method is removed (was previously deprecated.)
7778

7879

7980
``touch`` method now clears changed state

0 commit comments

Comments
 (0)