RUST-1119 Add bson::to_raw_document_buf function
#330
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickfreed
commented
Dec 2, 2021
src/ser/mod.rs
Outdated
| /// | ||
| /// let cat = Cat { name: "Garfield".to_string(), age: 43 }; | ||
| /// let doc = bson::to_raw_document_buf(&cat)?; | ||
| /// // assert_eq!(doc, rawdoc! { "name": "Garfield", "age": 43 }) |
There was a problem hiding this comment.
once #329 is merged, I'll rebase and uncomment this line.
abr-egn
approved these changes
Dec 2, 2021
isabelatkinson
approved these changes
Dec 3, 2021
patrickfreed
force-pushed
the
RUST-1119/to_raw_document
branch
from
44f0a2b to
8307afa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RUST-1119
This PR adds the
bson::to_raw_document_bufconvenience function. I originally set out to also addbson::to_raw_bsonas well (RUST-1110), but it looked like it was going to be a lot of effort for functionality that might not be all that useful. For now, I've split off just this function (which definitely will be useful) and am putting theto_raw_bsonwork on the backburner. Let me know if that sounds okay.